Added option to specify a maximum file size when recording an AEC dump.

talk/media/base/mediaengine.h

 /*
  * libjingle
  * Copyright 2004 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 101 matching lines @@
   virtual const std::vector<RtpHeaderExtension>&
       audio_rtp_header_extensions() = 0;
   virtual const std::vector<VideoCodec>& video_codecs() = 0;
   virtual const std::vector<RtpHeaderExtension>&
       video_rtp_header_extensions() = 0;
 
   // Logging control
   virtual void SetVoiceLogging(int min_sev, const char* filter) = 0;
   virtual void SetVideoLogging(int min_sev, const char* filter) = 0;
 
-  // Starts AEC dump using existing file.
-  virtual bool StartAecDump(rtc::PlatformFile file) = 0;
+  // Starts AEC dump using existing file, a maximum file size in bytes can be
+  // specified. If the log file grows to be larger than the limit, logging is
+  // stopped and the file is closed. If max_size_bytes is set to a value <= 0,

[kwiberg-webrtc, 2015/11/08 19:09:07]

Is it really the case that logging stops *after* the file has exceeded the
limit?

[ivoc, 2015/11/11 16:44:31]

It is not, fixed the comment.

+  // no limit will be used.
+  virtual bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) = 0;
 
   // Starts RtcEventLog using existing file.
   virtual bool StartRtcEventLog(rtc::PlatformFile file) = 0;
 
   // Stops recording an RtcEventLog.
   virtual void StopRtcEventLog() = 0;
 };
 
 
 #if !defined(DISABLE_MEDIA_ENGINE_FACTORY)
@@ skipping 80 matching lines @@
     return video_.rtp_header_extensions();
   }
 
   virtual void SetVoiceLogging(int min_sev, const char* filter) {
     voice_.SetLogging(min_sev, filter);
   }
   virtual void SetVideoLogging(int min_sev, const char* filter) {
     video_.SetLogging(min_sev, filter);
   }
 
-  virtual bool StartAecDump(rtc::PlatformFile file) {
-    return voice_.StartAecDump(file);
+  virtual bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) {
+    return voice_.StartAecDump(file, max_size_bytes);
   }
 
   virtual bool StartRtcEventLog(rtc::PlatformFile file) {
     return voice_.StartRtcEventLog(file);
   }
 
   virtual void StopRtcEventLog() { voice_.StopRtcEventLog(); }
 
  protected:
   VOICE voice_;
@@ skipping 19 matching lines @@
     *level = 0;
     return true;
   }
   bool SetOutputVolume(int level) { return true; }
   int GetInputLevel() { return 0; }
   const std::vector<AudioCodec>& codecs() { return codecs_; }
   const std::vector<RtpHeaderExtension>& rtp_header_extensions() {
     return rtp_header_extensions_;
   }
   void SetLogging(int min_sev, const char* filter) {}
-  bool StartAecDump(rtc::PlatformFile file) { return false; }
+  bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) {
+    return false;
+  }
   bool StartRtcEventLog(rtc::PlatformFile file) { return false; }
   void StopRtcEventLog() {}
 
  private:
   std::vector<AudioCodec> codecs_;
   std::vector<RtpHeaderExtension> rtp_header_extensions_;
 };
 
 // NullVideoEngine can be used with CompositeMediaEngine in the case where only
 // a voice engine is desired.
@@ skipping 33 matching lines @@
 class DataEngineInterface {
  public:
   virtual ~DataEngineInterface() {}
   virtual DataMediaChannel* CreateChannel(DataChannelType type) = 0;
   virtual const std::vector<DataCodec>& data_codecs() = 0;
 };
 
 }  // namespace cricket
 
 #endif  // TALK_MEDIA_BASE_MEDIAENGINE_H_