talk/app/webrtc/peerconnectioninterface.h - Issue 1413483003: Added option to specify a maximum file size when recording an AEC dump.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/peerconnectioninterface.h

Issue 1413483003: Added option to specify a maximum file size when recording an AEC dump. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Initial version Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« talk/app/webrtc/peerconnectionfactory.h ('K') | « talk/app/webrtc/peerconnectionfactoryproxy.h ('k') | talk/media/base/fakemediaengine.h » ('j') | talk/media/webrtc/webrtcvoiceengine.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: talk/app/webrtc/peerconnectioninterface.h

diff --git a/talk/app/webrtc/peerconnectioninterface.h b/talk/app/webrtc/peerconnectioninterface.h

index a5d98ffa747dd73e5f0585194b8e0ac604986acf..abc3d85f3bc053f7e090adfd37fc375d03a0a239 100644

--- a/talk/app/webrtc/peerconnectioninterface.h

+++ b/talk/app/webrtc/peerconnectioninterface.h

@@ -621,6 +621,9 @@ class PeerConnectionFactoryInterface : public rtc::RefCountInterface {

// http://crbug.com/264611.

virtual bool StartAecDump(rtc::PlatformFile file) = 0;

+ // Same as above, but a maximum file size in bytes can be specified.

+ virtual bool StartAecDump(rtc::PlatformFile file, int max_size_bytes) = 0;

// Starts RtcEventLog using existing file. Takes ownership of |file| and

// passes it on to VoiceEngine, which will take the ownership. If the

// operation fails the file will be closed. The logging will stop

« talk/app/webrtc/peerconnectionfactory.h ('K') | « talk/app/webrtc/peerconnectionfactoryproxy.h ('k') | talk/media/base/fakemediaengine.h » ('j') | talk/media/webrtc/webrtcvoiceengine.cc » ('J')