Added option to specify a maximum file size when recording an AEC dump.

talk/app/webrtc/peerconnectionfactory.h

Index: talk/app/webrtc/peerconnectionfactory.h
diff --git a/talk/app/webrtc/peerconnectionfactory.h b/talk/app/webrtc/peerconnectionfactory.h
index f8e0a40de2111d83d9cf530ba0d59f1e89109333..92885360943dcca0ecde3607c7b2ffd21b1db9e7 100644
--- a/talk/app/webrtc/peerconnectionfactory.h
+++ b/talk/app/webrtc/peerconnectionfactory.h
@@ -80,6 +80,7 @@ class PeerConnectionFactory : public PeerConnectionFactoryInterface {
                        AudioSourceInterface* audio_source) override;
 
   bool StartAecDump(rtc::PlatformFile file) override;
+  bool StartAecDump(rtc::PlatformFile file, int max_size_bytes) override;

[the sun, 2015/10/26 10:37:20]

Is the plan to subsequently remove the previous function? For this type of
interface I think it makes sense to allow max_size_bytes <= 0 to mean "no
limit".

To support the old interface until the clients are updated, you could do:

bool StartAecDump(rtc::PlatformFile file) override {
  StartAecDump(file, 0);
}

And then we could remove some of the duplicated code further down the chain.

[ivoc, 2015/11/05 13:14:45]

Since the previous function is not used (as far as I'm aware), it makes sense to
just remove it completely, which I did.

   bool StartRtcEventLog(rtc::PlatformFile file) override;
   void StopRtcEventLog() override;