Revert of Add aecdump support to audioproc_f. (patchset #8 id:200001 of https://codereview.webrtc.o…

Revert of Add aecdump support to audioproc_f. (patchset #8 id:200001 of https://codereview.webrtc.org/1409943002/ )

This is the second revert. The first attempt in https://codereview.webrtc.org/1423693008/
was missing a subtle curly brace caused by a merge conflict.
I'm going to let this one go through the CQ.

Reason for revert:
This breaks iOS GYP generation as described on http://www.webrtc.org/native-code/ios
I'm going to drive getting the build_with_libjingle=1 setting removed from the bots to match the official instructions.

See https://code.google.com/p/webrtc/issues/detail?id=4653 for more context, as this is exactly what that issue tries to solve.

Original issue's description:
> Add aecdump support to audioproc_f.
>
> Add a new interface to abstract away file operations. This CL temporarily
> removes support for dumping the output of reverse streams. It will be easy to
> restore in the new framework, although we may decide to only allow it with
> the aecdump format.
>
> We also now require the user to specify the output format, rather than
> defaulting to the input format.
>
> TEST=Bit-exact output to the previous audioproc_f version using an input wav
> file, and to the legacy audioproc using an aecdump file.
>
> Committed: https://crrev.com/bdafe31b86e9819b0adb9041f87e6194b7422b08
> Cr-Commit-Position: refs/heads/master@{#10460}

TBR=aluebs@webrtc.org,peah@webrtc.org,andrew@webrtc.org
BUG=

Committed: https://crrev.com/b7a5c16d2c6dbe5ca17fca86a3180b8aad5054f7
Cr-Commit-Position: refs/heads/master@{#10532}

[kjellander_webrtc, 2015-11-05 14:56:04]

Description was changed from

==========
Revert of Add aecdump support to audioproc_f. (patchset #8 id:200001 of
https://codereview.webrtc.org/1409943002/ )

This is the second revert. The first attempt in
https://codereview.webrtc.org/1423693008/
was missing a subtle curly brace caused by a merge conflict.
I'm going to let this one go through the CQ.

Reason for revert:
This breaks iOS GYP generation as described on
http://www.webrtc.org/native-code/ios
I'm going to drive getting the build_with_libjingle=1 setting removed from the
bots to match the official instructions.

See https://code.google.com/p/webrtc/issues/detail?id=4653 for more context, as
this is exactly what that issue tries to solve.

Original issue's description:
> Add aecdump support to audioproc_f.
>
> Add a new interface to abstract away file operations. This CL temporarily
> removes support for dumping the output of reverse streams. It will be easy to
> restore in the new framework, although we may decide to only allow it with
> the aecdump format.
>
> We also now require the user to specify the output format, rather than
> defaulting to the input format.
>
> TEST=Bit-exact output to the previous audioproc_f version using an input wav
> file, and to the legacy audioproc using an aecdump file.
>
> Committed: https://crrev.com/bdafe31b86e9819b0adb9041f87e6194b7422b08
> Cr-Commit-Position: refs/heads/master@{#10460}

TBR=aluebs@webrtc.org,peah@webrtc.org,andrew@webrtc.org
BUG=
==========

to

==========
Revert of Add aecdump support to audioproc_f. (patchset #8 id:200001 of
https://codereview.webrtc.org/1409943002/ )

This is the second revert. The first attempt in
https://codereview.webrtc.org/1423693008/
was missing a subtle curly brace caused by a merge conflict.
I'm going to let this one go through the CQ.

Reason for revert:
This breaks iOS GYP generation as described on
http://www.webrtc.org/native-code/ios
I'm going to drive getting the build_with_libjingle=1 setting removed from the
bots to match the official instructions.

See https://code.google.com/p/webrtc/issues/detail?id=4653 for more context, as
this is exactly what that issue tries to solve.

Original issue's description:
> Add aecdump support to audioproc_f.
>
> Add a new interface to abstract away file operations. This CL temporarily
> removes support for dumping the output of reverse streams. It will be easy to
> restore in the new framework, although we may decide to only allow it with
> the aecdump format.
>
> We also now require the user to specify the output format, rather than
> defaulting to the input format.
>
> TEST=Bit-exact output to the previous audioproc_f version using an input wav
> file, and to the legacy audioproc using an aecdump file.
>
> Committed: https://crrev.com/bdafe31b86e9819b0adb9041f87e6194b7422b08
> Cr-Commit-Position: refs/heads/master@{#10460}

TBR=aluebs@webrtc.org,peah@webrtc.org,andrew@webrtc.org
BUG=
==========

[kjellander_webrtc, 2015-11-05 14:57:03]

Sorry for the first bad revert. I should have at least run a few trybots since I
had to manually edit it. 
Lesson learned: don't blindly trust the revert+CQ.

[kjellander_webrtc, 2015-11-05 14:57:09]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2015-11-05 14:57:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412963007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412963007/1

[commit-bot: I haz the power, 2015-11-05 16:57:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 16:57:32]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[kjellander_webrtc, 2015-11-05 20:29:11]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2015-11-05 20:29:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412963007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412963007/1

[commit-bot: I haz the power, 2015-11-05 20:33:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-05 20:33:34]

Patchset 1 (id:??) landed as
https://crrev.com/b7a5c16d2c6dbe5ca17fca86a3180b8aad5054f7
Cr-Commit-Position: refs/heads/master@{#10532}

[aluebs-webrtc, 2015-11-05 20:35:57]

lgtm