Introduces Android API level linting, fixes all current API lint errors.

Introduces Android API level linting, fixes all current API lint errors.

This CL attempts to annotate accesses on >16 API levels using as
small scopes as possible. The TargetApi notations mean "yes, I know
I'm accessing a higher API and I take responsibility for gating the
call on Android API level". The Encoder/Decoder classes are annotated
on the whole class, but they're only accessed through JNI; we should
annotate on method level otherwise and preferably on private methods.

This patch also fixes some compiler-level deprecation warnings (i.e.
-Xlint:deprecation), but probably not all of them.

BUG=webrtc:5063
R=henrika@webrtc.org, kjellander@webrtc.org, magjed@webrtc.org

Committed: https://crrev.com/68876f990ea1ea365d2d8155df261b38ec9fbeff
Cr-Commit-Position: refs/heads/master@{#10624}

[phoglund, 2015-11-06 14:09:27]

phoglund@webrtc.org changed reviewers:
+ henrika@chromium.org, kjellander@chromium.org, magjed@chromium.org

[phoglund, 2015-11-06 14:09:28]

magjed: VideoCapturerAndroid, note the potential bug I flagged there!
henrika: voiceengine java code, note the two potential bugs I flagged.
kjellander: PRESUBMIT.py

https://codereview.webrtc.org/1412673008/diff/40001/talk/app/webrtc/java/andr...
File talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java (right):

https://codereview.webrtc.org/1412673008/diff/40001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java:475: //
TODO(phoglund): this method is broken on API level 14!
magjed: I think this can get called on API level 14, and in that case it will
blow up on the is*StabilizationSupported calls below which are 15 and up.

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
File
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java
(right):

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java:286:
// TODO(phoglund): I think this will break if called on API level <18!
henrika: I think the call on #287 blows up if API level < 18 since
AudioEffect.EFFECT_TYPE_AEC gets checked first, but it doesn't exist on lower
API levels.

It's possible queryEffects happens to return the empty collection in those
cases, but in that case we're just getting lucky. We should check the API level
in the method.

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
File
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java
(right):

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java:217:
effects.enable(maybeGetAudioSessionId(audioRecord));
henrika: you need to figure out something else here for API levels 14 and 15.
Either make audio effects do without the session id, or get the session id some
other way.

[phoglund, 2015-11-06 14:37:52]

https://codereview.webrtc.org/1412673008/diff/40001/talk/app/webrtc/java/andr...
File talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java (right):

https://codereview.webrtc.org/1412673008/diff/40001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java:475: //
TODO(phoglund): this method is broken on API level 14!
On 2015/11/06 14:09:28, phoglund wrote:
> magjed: I think this can get called on API level 14, and in that case it will
> blow up on the is*StabilizationSupported calls below which are 15 and up.

Never mind, we actually don't support level 14, so we're good here.

[henrika_webrtc, 2015-11-06 14:47:32]

henrika@webrtc.org changed reviewers:
+ henrika@webrtc.org

[henrika_webrtc, 2015-11-06 14:47:33]

IMHO, supporting 15 will not work for audio since audio effects are only
supported for 16 and above.

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
File
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java
(right):

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java:286:
// TODO(phoglund): I think this will break if called on API level <18!
Thanks. Could you add it in this CL as well?

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java:296:
enableAcousticEchoCanceler(audioSession);
I would like to maintain the previous version and not break out a new method
here and in all other places below.
Doing so for annotation purposes only bloats the code IMHO. Thanks.

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java:325:
@TargetApi(16)
Please remove these newly added methods. I understand why you add them but don't
think they are needed for that single purpose.

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
File
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java
(right):

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java:217:
effects.enable(maybeGetAudioSessionId(audioRecord));
It is not possible to support audio effects without the session id. This is the
only way to get it.
If we shall support pre 16, no audio effects will be available and the end
result will not be useful anyhow.
Makes no sense to build such a client IMHO.

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
File
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java
(right):

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java:94:
bytesWritten = writeOnLollipop(audioTrack, byteBuffer, sizeInBytes);
Please inline these as before. Thanks.

[henrika_webrtc, 2015-11-06 14:54:07]

Almost forgot; many thanks for fixing ;-)

[phoglund, 2015-11-06 15:00:44]

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
File
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java
(right):

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java:286:
// TODO(phoglund): I think this will break if called on API level <18!
On 2015/11/06 14:47:32, henrika_webrtc wrote:
> Thanks. Could you add it in this CL as well?

Sure.

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java:296:
enableAcousticEchoCanceler(audioSession);
On 2015/11/06 14:47:32, henrika_webrtc wrote:
> I would like to maintain the previous version and not break out a new method
> here and in all other places below.
> Doing so for annotation purposes only bloats the code IMHO. Thanks.

Well, I disagree, and so does the style guide:
https://engdoc.corp.google.com/eng/doc/devguide/java/styleguide.shtml?cl=head...

If you insist anyway I'll do it (since it's mostly you maintaining the code
anyway), but I'd recommend reconsidering. I think this gives more balance to the
method since it's already pretty long but I won't argue the point if you feel
strongly about it.

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
File
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java
(right):

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java:217:
effects.enable(maybeGetAudioSessionId(audioRecord));
On 2015/11/06 14:47:33, henrika_webrtc wrote:
> It is not possible to support audio effects without the session id. This is
the
> only way to get it.
> If we shall support pre 16, no audio effects will be available and the end
> result will not be useful anyhow.
> Makes no sense to build such a client IMHO.

Well, you're going to have to, since we've committed to support 15. Let's take
the discussion in the offline thread where we discuss which API levels to commit
to.

[henrika_webrtc, 2015-11-06 15:17:25]

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
File
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java
(right):

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java:296:
enableAcousticEchoCanceler(audioSession);
My point is that nothing in this class will work for pre 16 and I therefore
can't see the need for explicitly extract parts for a certain target.
All it does is to give you the impression that the class is useful even for <16
and it is not.

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
File
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java
(right):

https://codereview.webrtc.org/1412673008/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java:217:
effects.enable(maybeGetAudioSessionId(audioRecord));
On 2015/11/06 15:00:44, phoglund wrote:
> On 2015/11/06 14:47:33, henrika_webrtc wrote:
> > It is not possible to support audio effects without the session id. This is
> the
> > only way to get it.
> > If we shall support pre 16, no audio effects will be available and the end
> > result will not be useful anyhow.
> > Makes no sense to build such a client IMHO.
> 
> Well, you're going to have to, since we've committed to support 15. Let's take
> the discussion in the offline thread where we discuss which API levels to
commit
> to.

Acknowledged.

[perkj_webrtc, 2015-11-10 09:57:30]

perkj@webrtc.org changed reviewers:
+ perkj@webrtc.org

[perkj_webrtc, 2015-11-10 09:57:31]

Cool! A quick drive by,

https://codereview.webrtc.org/1412673008/diff/60001/talk/app/webrtc/java/src/...
File talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java (right):

https://codereview.webrtc.org/1412673008/diff/60001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java:54:
@TargetApi(19)
This should be 16. Please rebase and try again, Otherwise, please let us know
what it complains about.

https://codereview.webrtc.org/1412673008/diff/60001/talk/app/webrtc/java/src/...
File talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java (right):

https://codereview.webrtc.org/1412673008/diff/60001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java:48:
@TargetApi(19)
This should be 16.

[perkj_webrtc, 2015-11-10 09:59:30]

Description was changed from

==========
Introduces Android API level linting, fixes all current lint errors.

This presubmit is a bit unusual in that it needs to compile the java
code. This is because the Android linter runs on .class files, and
therefore we need to ensure we're compiled up to date. This is going
to break people that try to change java files in a checkout where
there aren't up to date ninja files, but I think that's acceptable.

This CL attempts to annotate accesses on >14 API levels using as
small scopes as possible. The TargetApi notations mean "yes, I know
I'm accessing a higher API and I take responsibility for gating the
call on Android API level". The Encoder/Decoder classes are annotated
on the whole class, but they're only accessed through JNI; we should
annotate on method level otherwise and preferably on private methods.

Note: this CL notes one major bug where we're broken on API level <16,
but does not fix it. This should be done in a followup CL.

BUG=webrtc:5063
==========

to

==========
Introduces Android API level linting, fixes all current lint errors.

This presubmit is a bit unusual in that it needs to compile the java
code. This is because the Android linter runs on .class files, and
therefore we need to ensure we're compiled up to date. This is going
to break people that try to change java files in a checkout where
there aren't up to date ninja files, but I think that's acceptable.

This CL attempts to annotate accesses on >14 API levels using as
small scopes as possible. The TargetApi notations mean "yes, I know
I'm accessing a higher API and I take responsibility for gating the
call on Android API level". The Encoder/Decoder classes are annotated
on the whole class, but they're only accessed through JNI; we should
annotate on method level otherwise and preferably on private methods.

Note: this CL notes one major bug where we're broken on API level <16,
but does not fix it. This should be done in a followup CL.

BUG=webrtc:5063
==========

[perkj_webrtc, 2015-11-10 09:59:30]

perkj@webrtc.org changed reviewers:
+ magjed@webrtc.org
- magjed@chromium.org

[phoglund, 2015-11-10 11:14:29]

On 2015/11/10 09:57:31, perkj1 wrote:
> Cool! A quick drive by,
> 
>
https://codereview.webrtc.org/1412673008/diff/60001/talk/app/webrtc/java/src/...
> File talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java (right):
> 
>
https://codereview.webrtc.org/1412673008/diff/60001/talk/app/webrtc/java/src/...
> talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java:54:
> @TargetApi(19)
> This should be 16. Please rebase and try again, Otherwise, please let us know
> what it complains about.
> 
>
https://codereview.webrtc.org/1412673008/diff/60001/talk/app/webrtc/java/src/...
> File talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java (right):
> 
>
https://codereview.webrtc.org/1412673008/diff/60001/talk/app/webrtc/java/src/...
> talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java:48:
> @TargetApi(19)
> This should be 16.

** Presubmit ERRORS **
/usr/local/google/home/phoglund/dev/webrtc/src/talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java:308:
Error: Call requires API level 19 (current min is 16):
android.media.MediaCodec#setParameters [NewApi]

        mediaCodec.setParameters(b);

                   ~~~~~~~~~~~~~

/usr/local/google/home/phoglund/dev/webrtc/src/talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java:367:
Error: Call requires API level 19 (current min is 16):
android.media.MediaCodec#setParameters [NewApi]

      mediaCodec.setParameters(params);

                 ~~~~~~~~~~~~~

I will tag them as 19 for now and you can fix that when you fix the above calls.

[phoglund, 2015-11-10 11:16:54]

PTAL

[henrika_webrtc, 2015-11-10 11:20:11]

LGTM modules/audio_device

[kjellander_webrtc, 2015-11-10 12:32:50]

kjellander@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2015-11-10 12:32:51]

I'm sorry for not reviewing this earlier.
I think it's better to run the lint checking on compile time as Chromium
currently does it.

After some research (compiling AppRTCDemo with -v) I found that we actually
already do that:
[2435/2440] cd ../../webrtc; python ../build/android/gyp/lint.py
"--lint-path=/ssd/webrtc/src/third_party/android_tools/sdk//tools/lint"
"--config-path=../build/android/lint/suppressions.xml"
"--processed-config-path=../out/Release/AppRTCDemo/lint_config.xml"
"--manifest-path=examples/androidapp/AndroidManifest.xml"
"--result-path=../out/Release/AppRTCDemo/lint_result.xml"
"--resource-dir=examples/androidapp/res" "--product-dir=../out/Release"
"--src-dirs=examples/androidapp/src"
"--jar-path=../out/Release/lib.java/chromium_apk_AppRTCDemo.jar"
--can-fail-build "--stamp=../out/Release/AppRTCDemo/lint.stamp" ""

This comes from
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/lint...
which is included in 
https://code.google.com/p/chromium/codesearch#chromium/src/build/java_apk.gyp...,
which our AppRTCDemo uses in the GYP target
(https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc...)

We should be able to specify our own lint/suppression file as well (similar to
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/lint...),
if needed. Might need some fiddling with GYP variables and in worst case landing
a CL in Chrome to make it possible if it isn't currently.

[magjed_webrtc, 2015-11-10 13:24:04]

lgtm talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java

[phoglund, 2015-11-12 12:31:55]

OK kjellander, PTAL

[phoglund, 2015-11-12 12:34:22]

Description was changed from

==========
Introduces Android API level linting, fixes all current lint errors.

This presubmit is a bit unusual in that it needs to compile the java
code. This is because the Android linter runs on .class files, and
therefore we need to ensure we're compiled up to date. This is going
to break people that try to change java files in a checkout where
there aren't up to date ninja files, but I think that's acceptable.

This CL attempts to annotate accesses on >14 API levels using as
small scopes as possible. The TargetApi notations mean "yes, I know
I'm accessing a higher API and I take responsibility for gating the
call on Android API level". The Encoder/Decoder classes are annotated
on the whole class, but they're only accessed through JNI; we should
annotate on method level otherwise and preferably on private methods.

Note: this CL notes one major bug where we're broken on API level <16,
but does not fix it. This should be done in a followup CL.

BUG=webrtc:5063
==========

to

==========
Introduces Android API level linting, fixes all current API lint errors.

This CL attempts to annotate accesses on >16 API levels using as
small scopes as possible. The TargetApi notations mean "yes, I know
I'm accessing a higher API and I take responsibility for gating the
call on Android API level". The Encoder/Decoder classes are annotated
on the whole class, but they're only accessed through JNI; we should
annotate on method level otherwise and preferably on private methods.

This patch also fixes some compiler-level deprecation warnings (i.e. 
-Xlint:deprecation), but probably not all of them.

BUG=webrtc:5063
==========

[kjellander_webrtc, 2015-11-12 13:02:18]

Nice work here! Looks good but I'd like to move the suppressions.xml file to a
place that makes more sense for all of our code.

https://codereview.webrtc.org/1412673008/diff/120001/talk/app/webrtc/java/lin...
File talk/app/webrtc/java/lint/AndroidManifest.xml (right):

https://codereview.webrtc.org/1412673008/diff/120001/talk/app/webrtc/java/lin...
talk/app/webrtc/java/lint/AndroidManifest.xml:3: Copyright (c) 2012 The Chromium
Authors. All rights reserved.  Use of this
Change to WebRTC license and set 2015

https://codereview.webrtc.org/1412673008/diff/120001/talk/app/webrtc/java/lin...
File talk/app/webrtc/java/lint/suppressions.xml (right):

https://codereview.webrtc.org/1412673008/diff/120001/talk/app/webrtc/java/lin...
talk/app/webrtc/java/lint/suppressions.xml:1: <?xml version="1.0"
encoding="utf-8"?>
I think it makes more sense for us to have a global suppressions file in
webrtc/build/android/lint/suppressions.xml that applies to all projects.
Then it also matches the Chromium one we're overriding
(https://code.google.com/p/chromium/codesearch#chromium/src/build/android/lint...).
I've been doing that with other files, like the
webrtc/build/android/test_runner.py.

https://codereview.webrtc.org/1412673008/diff/120001/talk/app/webrtc/java/lin...
talk/app/webrtc/java/lint/suppressions.xml:14: That file is located at
app/webrtc/java/lint/AndroidManifest.xml. -->
If you agree with the above this line needs to be removed.

https://codereview.webrtc.org/1412673008/diff/120001/talk/libjingle.gyp
File talk/libjingle.gyp (right):

https://codereview.webrtc.org/1412673008/diff/120001/talk/libjingle.gyp#newco...
talk/libjingle.gyp:235: 'chromium_code': 1,
I'd like us to do this for more Android Java targets in WebRTC, but that can be
done in a follow-up CL.

[phoglund, 2015-11-12 13:21:35]

PTAL

https://codereview.webrtc.org/1412673008/diff/120001/talk/app/webrtc/java/lin...
File talk/app/webrtc/java/lint/AndroidManifest.xml (right):

https://codereview.webrtc.org/1412673008/diff/120001/talk/app/webrtc/java/lin...
talk/app/webrtc/java/lint/AndroidManifest.xml:3: Copyright (c) 2012 The Chromium
Authors. All rights reserved.  Use of this
On 2015/11/12 13:02:18, kjellander (webrtc) wrote:
> Change to WebRTC license and set 2015

We don't have licenses for our other AndroidManifest files so I just removed it.

https://codereview.webrtc.org/1412673008/diff/120001/talk/app/webrtc/java/lin...
File talk/app/webrtc/java/lint/suppressions.xml (right):

https://codereview.webrtc.org/1412673008/diff/120001/talk/app/webrtc/java/lin...
talk/app/webrtc/java/lint/suppressions.xml:1: <?xml version="1.0"
encoding="utf-8"?>
On 2015/11/12 13:02:18, kjellander (webrtc) wrote:
> I think it makes more sense for us to have a global suppressions file in
> webrtc/build/android/lint/suppressions.xml that applies to all projects.
> Then it also matches the Chromium one we're overriding
>
(https://code.google.com/p/chromium/codesearch#chromium/src/build/android/lint...).
> I've been doing that with other files, like the
> webrtc/build/android/test_runner.py.

Done.

https://codereview.webrtc.org/1412673008/diff/120001/talk/app/webrtc/java/lin...
talk/app/webrtc/java/lint/suppressions.xml:14: That file is located at
app/webrtc/java/lint/AndroidManifest.xml. -->
On 2015/11/12 13:02:18, kjellander (webrtc) wrote:
> If you agree with the above this line needs to be removed.

Well, they're still needed, but the file will be in a different location. I just
updated the comment.

https://codereview.webrtc.org/1412673008/diff/120001/talk/libjingle.gyp
File talk/libjingle.gyp (right):

https://codereview.webrtc.org/1412673008/diff/120001/talk/libjingle.gyp#newco...
talk/libjingle.gyp:235: 'chromium_code': 1,
On 2015/11/12 13:02:18, kjellander (webrtc) wrote:
> I'd like us to do this for more Android Java targets in WebRTC, but that can
be
> done in a follow-up CL.

This covers all our java production code I think, but yeah, if we find more
targets we can sure add those.

[kjellander_webrtc, 2015-11-12 13:49:33]

lgtm assuming you'll remove the Chromium copyright header.

https://codereview.webrtc.org/1412673008/diff/140001/webrtc/build/android/And...
File webrtc/build/android/AndroidManifest.xml (right):

https://codereview.webrtc.org/1412673008/diff/140001/webrtc/build/android/And...
webrtc/build/android/AndroidManifest.xml:3: Copyright (c) 2012 The Chromium
Authors. All rights reserved.  Use of this
You forgot to remove this copyright header.

[phoglund, 2015-11-12 13:51:29]

https://codereview.webrtc.org/1412673008/diff/140001/webrtc/build/android/And...
File webrtc/build/android/AndroidManifest.xml (right):

https://codereview.webrtc.org/1412673008/diff/140001/webrtc/build/android/And...
webrtc/build/android/AndroidManifest.xml:3: Copyright (c) 2012 The Chromium
Authors. All rights reserved.  Use of this
On 2015/11/12 13:49:33, kjellander (webrtc) wrote:
> You forgot to remove this copyright header.

Done.

[phoglund, 2015-11-12 13:51:35]

The CQ bit was checked by phoglund@webrtc.org

[phoglund, 2015-11-12 13:51:35]

The patchset sent to the CQ was uploaded after l-g-t-m from henrika@webrtc.org,
magjed@webrtc.org, kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1412673008/#ps160001 (title:
"Remove copyright header.")

[commit-bot: I haz the power, 2015-11-12 13:51:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412673008/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412673008/160001

[commit-bot: I haz the power, 2015-11-12 14:04:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-12 14:04:39]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/build...)

[phoglund, 2015-11-12 14:09:21]

The CQ bit was checked by phoglund@webrtc.org

[phoglund, 2015-11-12 14:09:21]

The patchset sent to the CQ was uploaded after l-g-t-m from henrika@webrtc.org,
magjed@webrtc.org, kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1412673008/#ps180001 (title:
"Correcting xml paths")

[commit-bot: I haz the power, 2015-11-12 14:09:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1412673008/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1412673008/180001

[commit-bot: I haz the power, 2015-11-12 16:09:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-12 16:09:56]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[phoglund, 2015-11-12 16:37:07]

Committed patchset #10 (id:180001) manually as
68876f990ea1ea365d2d8155df261b38ec9fbeff (presubmit successful).

[commit-bot: I haz the power, 2015-11-12 16:37:11]

Patchset 10 (id:??) landed as
https://crrev.com/68876f990ea1ea365d2d8155df261b38ec9fbeff
Cr-Commit-Position: refs/heads/master@{#10624}