talk/app/webrtc/java/lint/suppressions.xml - Issue 1412673008: Introduces Android API level linting, fixes all current API lint errors.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: talk/app/webrtc/java/lint/suppressions.xml

Issue 1412673008: Introduces Android API level linting, fixes all current API lint errors. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Add comments, rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« talk/app/webrtc/java/lint/AndroidManifest.xml ('K') | « talk/app/webrtc/java/lint/AndroidManifest.xml ('k') | talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java » ('j') | talk/libjingle.gyp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	kjellander_webrtc 2015/11/12 13:02:18 I think it makes more sense for us to have a globa I think it makes more sense for us to have a global suppressions file in webrtc/build/android/lint/suppressions.xml that applies to all projects. Then it also matches the Chromium one we're overriding (https://code.google.com/p/chromium/codesearch#chromium/src/build/android/lint...). I've been doing that with other files, like the webrtc/build/android/test_runner.py. phoglund 2015/11/12 13:21:34 Done. Show quoted text On 2015/11/12 13:02:18, kjellander (webrtc) wrote: > I think it makes more sense for us to have a global suppressions file in > webrtc/build/android/lint/suppressions.xml that applies to all projects. > Then it also matches the Chromium one we're overriding > (https://code.google.com/p/chromium/codesearch#chromium/src/build/android/lint...). > I've been doing that with other files, like the > webrtc/build/android/test_runner.py. Done.
	2 <lint>

	3 <issue id="NewApi"></issue>

	4

	5 <issue id="Locale" severity="ignore"/>

	6 <issue id="SdCardPath" severity="ignore"/>

	7 <issue id="UseValueOf" severity="ignore"/>

	8 <issue id="InlinedApi" severity="ignore"/>

	9 <issue id="DefaultLocale" severity="ignore"/>

	10 <issue id="Assert" severity="ignore"/>

	11 <issue id="UseSparseArrays" severity="ignore"/>

	12

	13 <!-- These are just from the dummy AndroidManifest.xml we use for linting.

	14 That file is located at app/webrtc/java/lint/AndroidManifest.xml. -->
	kjellander_webrtc 2015/11/12 13:02:18 If you agree with the above this line needs to be If you agree with the above this line needs to be removed. phoglund 2015/11/12 13:21:34 Well, they're still needed, but the file will be i Show quoted text On 2015/11/12 13:02:18, kjellander (webrtc) wrote: > If you agree with the above this line needs to be removed. Well, they're still needed, but the file will be in a different location. I just updated the comment.
	15 <issue id="MissingApplicationIcon" severity="ignore"/>

	16 <issue id="AllowBackup" severity="ignore"/>

	17 <issue id="MissingVersion" severity="ignore"/>

	18 </lint>

OLD	NEW