Move ownership of receive ViEChannel to VideoReceiveStream.

Move ownership of receive ViEChannel to VideoReceiveStream.

This CL changes as little as possible and I'll follow up later with
ownership of the other members in ChannelGroup.

The next step is to remove the id used for channels.

BUG=webrtc:5079
Committed: https://crrev.com/a20de2030f7f3a3c5e252ccc76a467109f5a93dc
Cr-Commit-Position: refs/heads/master@{#10318}

[mflodman, 2015-10-16 11:04:47]

mflodman@webrtc.org changed reviewers:
+ pbos@webrtc.org

[pbos-webrtc, 2015-10-16 12:49:57]

lgtm, please move stats_proxy_ instead of doing a manual reset.

https://codereview.webrtc.org/1411723002/diff/20001/webrtc/video/video_receiv...
File webrtc/video/video_receive_stream.cc (right):

https://codereview.webrtc.org/1411723002/diff/20001/webrtc/video/video_receiv...
webrtc/video/video_receive_stream.cc:304: // This must be deleted before
ReceiveStatisticsProxy, due to callbacks.
Shouldn't ReceiveStatisticsProxy be declared before vie_channel_ then? I'd
rather enforce destruction order than add a reset().

https://codereview.webrtc.org/1411723002/diff/20001/webrtc/video/video_receiv...
File webrtc/video/video_receive_stream.h (right):

https://codereview.webrtc.org/1411723002/diff/20001/webrtc/video/video_receiv...
webrtc/video/video_receive_stream.h:82: rtc::scoped_ptr<ReceiveStatisticsProxy>
stats_proxy_;
I think you can move this one to the top since it should outlive vie_channel_

[pbos-webrtc, 2015-10-16 12:50:53]

please correct the CL desc spelling: "the other members in ChannelGroup"

[mflodman, 2015-10-16 13:31:57]

https://codereview.webrtc.org/1411723002/diff/20001/webrtc/video/video_receiv...
File webrtc/video/video_receive_stream.cc (right):

https://codereview.webrtc.org/1411723002/diff/20001/webrtc/video/video_receiv...
webrtc/video/video_receive_stream.cc:304: // This must be deleted before
ReceiveStatisticsProxy, due to callbacks.
On 2015/10/16 12:49:57, pbos-webrtc wrote:
> Shouldn't ReceiveStatisticsProxy be declared before vie_channel_ then? I'd
> rather enforce destruction order than add a reset().

Done.

https://codereview.webrtc.org/1411723002/diff/20001/webrtc/video/video_receiv...
File webrtc/video/video_receive_stream.h (right):

https://codereview.webrtc.org/1411723002/diff/20001/webrtc/video/video_receiv...
webrtc/video/video_receive_stream.h:82: rtc::scoped_ptr<ReceiveStatisticsProxy>
stats_proxy_;
On 2015/10/16 12:49:57, pbos-webrtc wrote:
> I think you can move this one to the top since it should outlive vie_channel_

Done.

[mflodman, 2015-10-16 13:32:14]

The CQ bit was checked by mflodman@webrtc.org

[mflodman, 2015-10-16 13:32:14]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1411723002/#ps40001 (title:
"pbos review")

[commit-bot: I haz the power, 2015-10-16 13:32:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411723002/40001

[commit-bot: I haz the power, 2015-10-16 15:32:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-16 15:32:33]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[mflodman, 2015-10-19 04:22:45]

The CQ bit was checked by mflodman@webrtc.org

[commit-bot: I haz the power, 2015-10-19 04:22:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1411723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1411723002/40001

[commit-bot: I haz the power, 2015-10-19 05:08:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-19 05:08:40]

Patchset 3 (id:??) landed as
https://crrev.com/a20de2030f7f3a3c5e252ccc76a467109f5a93dc
Cr-Commit-Position: refs/heads/master@{#10318}