Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Side by Side Diff: webrtc/video/video_receive_stream.h

Issue 1411723002: Move ownership of receive ViEChannel to VideoReceiveStream. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Delete ViEChannel first. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 23 matching lines...) Expand all
34 namespace internal { 34 namespace internal {
35 35
36 class VideoReceiveStream : public webrtc::VideoReceiveStream, 36 class VideoReceiveStream : public webrtc::VideoReceiveStream,
37 public I420FrameCallback, 37 public I420FrameCallback,
38 public VideoRenderCallback { 38 public VideoRenderCallback {
39 public: 39 public:
40 VideoReceiveStream(int num_cpu_cores, 40 VideoReceiveStream(int num_cpu_cores,
41 ChannelGroup* channel_group, 41 ChannelGroup* channel_group,
42 int channel_id, 42 int channel_id,
43 const VideoReceiveStream::Config& config, 43 const VideoReceiveStream::Config& config,
44 webrtc::VoiceEngine* voice_engine); 44 webrtc::VoiceEngine* voice_engine,
45 ProcessThread* process_thread);
45 ~VideoReceiveStream() override; 46 ~VideoReceiveStream() override;
46 47
47 // webrtc::ReceiveStream implementation. 48 // webrtc::ReceiveStream implementation.
48 void Start() override; 49 void Start() override;
49 void Stop() override; 50 void Stop() override;
50 void SignalNetworkState(NetworkState state) override; 51 void SignalNetworkState(NetworkState state) override;
51 bool DeliverRtcp(const uint8_t* packet, size_t length) override; 52 bool DeliverRtcp(const uint8_t* packet, size_t length) override;
52 bool DeliverRtp(const uint8_t* packet, 53 bool DeliverRtp(const uint8_t* packet,
53 size_t length, 54 size_t length,
54 const PacketTime& packet_time) override; 55 const PacketTime& packet_time) override;
(...skipping 12 matching lines...) Expand all
67 68
68 void SetSyncChannel(VoiceEngine* voice_engine, int audio_channel_id); 69 void SetSyncChannel(VoiceEngine* voice_engine, int audio_channel_id);
69 70
70 private: 71 private:
71 TransportAdapter transport_adapter_; 72 TransportAdapter transport_adapter_;
72 EncodedFrameCallbackAdapter encoded_frame_proxy_; 73 EncodedFrameCallbackAdapter encoded_frame_proxy_;
73 const VideoReceiveStream::Config config_; 74 const VideoReceiveStream::Config config_;
74 Clock* const clock_; 75 Clock* const clock_;
75 76
76 ChannelGroup* const channel_group_; 77 ChannelGroup* const channel_group_;
77 const int channel_id_;
78 78
79 ViEChannel* vie_channel_; 79 rtc::scoped_ptr<ViEChannel> vie_channel_;
80 rtc::scoped_ptr<IncomingVideoStream> incoming_video_stream_; 80 rtc::scoped_ptr<IncomingVideoStream> incoming_video_stream_;
81 81
82 rtc::scoped_ptr<ReceiveStatisticsProxy> stats_proxy_; 82 rtc::scoped_ptr<ReceiveStatisticsProxy> stats_proxy_;
pbos-webrtc 2015/10/16 12:49:57 I think you can move this one to the top since it
mflodman 2015/10/16 13:31:57 Done.
83 }; 83 };
84 } // namespace internal 84 } // namespace internal
85 } // namespace webrtc 85 } // namespace webrtc
86 86
87 #endif // WEBRTC_VIDEO_VIDEO_RECEIVE_STREAM_H_ 87 #endif // WEBRTC_VIDEO_VIDEO_RECEIVE_STREAM_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698