Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1411083006: Revert of Implement AudioReceiveStream::GetStats(). (Closed)

Created:
5 years, 2 months ago by the sun
Modified:
5 years, 2 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Implement AudioReceiveStream::GetStats(). (patchset #19 id:360001 of https://codereview.webrtc.org/1390753002/ ) Reason for revert: webrtc_perf_tests started failing on Win32 Release, Mac32 Release and Linux64 Release (all running large tests). These were not caught by try bots. Original issue's description: > Implement AudioReceiveStream::GetStats(). > > R=tommi@webrtc.org > TBR=hta@webrtc.org > BUG=webrtc:4690 > > Committed: https://chromium.googlesource.com/external/webrtc/+/a457752f4afc496ed7f4d6b584b08d8635f18cc0 TBR=tommi@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4690 Committed: https://crrev.com/43e83d44f01683fbd304e37d47d2f6db0d52660d Cr-Commit-Position: refs/heads/master@{#10340}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -873 lines) Patch
M talk/media/webrtc/fakewebrtccall.h View 2 chunks +4 lines, -7 lines 0 comments Download
M talk/media/webrtc/fakewebrtccall.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M talk/media/webrtc/fakewebrtcvoiceengine.h View 5 chunks +67 lines, -3 lines 0 comments Download
M talk/media/webrtc/webrtcvoe.h View 5 chunks +14 lines, -2 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 5 chunks +75 lines, -34 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine_unittest.cc View 6 chunks +64 lines, -102 lines 0 comments Download
M webrtc/audio/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/audio/audio_receive_stream.h View 2 chunks +1 line, -10 lines 0 comments Download
M webrtc/audio/audio_receive_stream.cc View 5 chunks +4 lines, -102 lines 0 comments Download
M webrtc/audio/audio_receive_stream_unittest.cc View 3 chunks +4 lines, -66 lines 0 comments Download
D webrtc/audio/conversion.h View 1 chunk +0 lines, -21 lines 0 comments Download
D webrtc/audio/scoped_voe_interface.h View 1 chunk +0 lines, -43 lines 0 comments Download
M webrtc/audio/webrtc_audio.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/audio_receive_stream.h View 1 chunk +1 line, -26 lines 0 comments Download
M webrtc/call/bitrate_estimator_tests.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M webrtc/call/call.cc View 5 chunks +9 lines, -13 lines 0 comments Download
M webrtc/call/call_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
D webrtc/test/fake_voice_engine.h View 1 chunk +0 lines, -421 lines 0 comments Download
M webrtc/test/webrtc_test_common.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/voice_engine/voice_engine_impl.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
the sun
Created Revert of Implement AudioReceiveStream::GetStats().
5 years, 2 months ago (2015-10-20 13:40:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411083006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411083006/1
5 years, 2 months ago (2015-10-20 13:40:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 13:41:05 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 13:41:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43e83d44f01683fbd304e37d47d2f6db0d52660d
Cr-Commit-Position: refs/heads/master@{#10340}

Powered by Google App Engine
This is Rietveld 408576698