Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1410113007: Update webrtc/base/common.h after recent _DEBUG->!NDEBUG change. (Closed)

Created:
5 years, 1 month ago by tommi
Modified:
5 years, 1 month ago
Reviewers:
tfarina
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update webrtc/base/common.h after recent _DEBUG->!NDEBUG change. R=tfarina@chromium.org TBR=tfarina@chromium.org BUG= Committed: https://crrev.com/e502bbe138599a10fe530cb789e3f715a56fd461 Cr-Commit-Position: refs/heads/master@{#10470}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M webrtc/base/common.h View 1 chunk +5 lines, -1 line 3 comments Download

Messages

Total messages: 8 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410113007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410113007/1
5 years, 1 month ago (2015-10-31 21:29:26 UTC) #2
tommi
5 years, 1 month ago (2015-10-31 21:29:30 UTC) #3
tfarina
https://codereview.webrtc.org/1410113007/diff/1/webrtc/base/common.h File webrtc/base/common.h (right): https://codereview.webrtc.org/1410113007/diff/1/webrtc/base/common.h#newcode64 webrtc/base/common.h:64: #if !defined(NDEBUG) LGTM
5 years, 1 month ago (2015-10-31 21:33:38 UTC) #4
tfarina
Unrelated question below. https://codereview.webrtc.org/1410113007/diff/1/webrtc/base/common.h File webrtc/base/common.h (right): https://codereview.webrtc.org/1410113007/diff/1/webrtc/base/common.h#newcode57 webrtc/base/common.h:57: #define ARRAY_SIZE(x) (static_cast<int>(sizeof(x) / sizeof(x[0]))) Can ...
5 years, 1 month ago (2015-10-31 21:35:32 UTC) #5
tommi
https://codereview.webrtc.org/1410113007/diff/1/webrtc/base/common.h File webrtc/base/common.h (right): https://codereview.webrtc.org/1410113007/diff/1/webrtc/base/common.h#newcode57 webrtc/base/common.h:57: #define ARRAY_SIZE(x) (static_cast<int>(sizeof(x) / sizeof(x[0]))) On 2015/10/31 21:35:32, tfarina ...
5 years, 1 month ago (2015-10-31 21:38:28 UTC) #6
tommi
Committed patchset #1 (id:1) manually as e502bbe138599a10fe530cb789e3f715a56fd461 (presubmit successful).
5 years, 1 month ago (2015-10-31 21:41:50 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-31 21:41:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e502bbe138599a10fe530cb789e3f715a56fd461
Cr-Commit-Position: refs/heads/master@{#10470}

Powered by Google App Engine
This is Rietveld 408576698