Update webrtc/base/common.h after recent _DEBUG->!NDEBUG change.

webrtc/base/common.h

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 36 matching lines @@
 #ifndef strnicmp
 #define strnicmp(x, y, n) strncasecmp(x, y, n)
 #endif
 
 #ifndef stricmp
 #define stricmp(x, y) strcasecmp(x, y)
 #endif
 
 #endif  // !defined(WEBRTC_WIN)
 
 #define ARRAY_SIZE(x) (static_cast<int>(sizeof(x) / sizeof(x[0])))

[tfarina, 2015/10/31 21:35:32]

Can we put this inline with the version in Chromium base/macros.h:arraysize?

https://chromium.googlesource.com/chromium/src/+/master/base/macros.h#47

[tommi, 2015/10/31 21:38:28]

There is a webrtc/base/arraysize.h already actually and it's what's being used
in new code. This macro will go away.

 
 /////////////////////////////////////////////////////////////////////////////
 // Assertions
 /////////////////////////////////////////////////////////////////////////////
 
 #ifndef ENABLE_DEBUG
-#define ENABLE_DEBUG _DEBUG
+#if !defined(NDEBUG)

[tfarina, 2015/10/31 21:33:38]

LGTM

+#define ENABLE_DEBUG 1
+#else
+#define ENABLE_DEBUG 0
+#endif
 #endif  // !defined(ENABLE_DEBUG)
 
 // Even for release builds, allow for the override of LogAssert. Though no
 // macro is provided, this can still be used for explicit runtime asserts
 // and allow applications to override the assert behavior.
 
 namespace rtc {
 
 
 // If a debugger is attached, triggers a debugger breakpoint. If a debugger is
@@ skipping 116 matching lines @@
 // libjingle are merged.
 #if !defined(WARN_UNUSED_RESULT)
 #if defined(__GNUC__) || defined(__clang__)
 #define WARN_UNUSED_RESULT __attribute__((warn_unused_result))
 #else
 #define WARN_UNUSED_RESULT
 #endif
 #endif  // WARN_UNUSED_RESULT
 
 #endif  // WEBRTC_BASE_COMMON_H_    // NOLINT