Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2779)

Issue 1407883007: Removing trace checks in VoETestManager. (Closed)

Created:
5 years, 1 month ago by minyue-webrtc
Modified:
5 years, 1 month ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, hlundin-webrtc, peah-webrtc, henrika_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing trace checks in VoETestManager. Trace checks in the ctor and dtor of VoETestManager are removed, since they can fail if there are more than one VoETestManager (or VoE) used in a test. BUG= Committed: https://crrev.com/e56c7636912db2f859c4d1bf11e614780001bb0f Cr-Commit-Position: refs/heads/master@{#10507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M webrtc/voice_engine/test/auto_test/voe_standard_test.cc View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
minyue-webrtc
Hi Fredrik, Would you help review this CL?
5 years, 1 month ago (2015-11-04 09:35:18 UTC) #3
the sun
lgtm
5 years, 1 month ago (2015-11-04 12:24:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407883007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407883007/1
5 years, 1 month ago (2015-11-04 12:24:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 1 month ago (2015-11-04 14:25:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407883007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407883007/1
5 years, 1 month ago (2015-11-04 15:07:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 15:11:52 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 15:11:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e56c7636912db2f859c4d1bf11e614780001bb0f
Cr-Commit-Position: refs/heads/master@{#10507}

Powered by Google App Engine
This is Rietveld 408576698