Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: webrtc/voice_engine/test/auto_test/voe_standard_test.cc

Issue 1407883007: Removing trace checks in VoETestManager. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 voe_apm_(0) { 110 voe_apm_(0) {
111 } 111 }
112 112
113 VoETestManager::~VoETestManager() { 113 VoETestManager::~VoETestManager() {
114 } 114 }
115 115
116 bool VoETestManager::Init() { 116 bool VoETestManager::Init() {
117 if (initialized_) 117 if (initialized_)
118 return true; 118 return true;
119 119
120 if (VoiceEngine::SetTraceFile(NULL) != -1) {
121 // should not be possible to call a Trace method before the VoE is
122 // created
123 TEST_LOG("\nError at line: %i (VoiceEngine::SetTraceFile()"
124 "should fail)!\n", __LINE__);
125 return false;
126 }
127
128 voice_engine_ = VoiceEngine::Create(); 120 voice_engine_ = VoiceEngine::Create();
129 if (!voice_engine_) { 121 if (!voice_engine_) {
130 TEST_LOG("Failed to create VoiceEngine\n"); 122 TEST_LOG("Failed to create VoiceEngine\n");
131 return false; 123 return false;
132 } 124 }
133 125
134 return true; 126 return true;
135 } 127 }
136 128
137 void VoETestManager::GetInterfaces() { 129 void VoETestManager::GetInterfaces() {
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 if (voe_neteq_stats_) { 215 if (voe_neteq_stats_) {
224 voe_neteq_stats_->Release(); 216 voe_neteq_stats_->Release();
225 voe_neteq_stats_ = NULL; 217 voe_neteq_stats_ = NULL;
226 } 218 }
227 #endif 219 #endif
228 if (false == VoiceEngine::Delete(voice_engine_)) { 220 if (false == VoiceEngine::Delete(voice_engine_)) {
229 TEST_LOG("\n\nVoiceEngine::Delete() failed. \n"); 221 TEST_LOG("\n\nVoiceEngine::Delete() failed. \n");
230 releaseOK = false; 222 releaseOK = false;
231 } 223 }
232 224
233 if (VoiceEngine::SetTraceFile(NULL) != -1) {
234 TEST_LOG("\nError at line: %i (VoiceEngine::SetTraceFile()"
235 "should fail)!\n", __LINE__);
236 }
237
238 return (releaseOK == true) ? 0 : -1; 225 return (releaseOK == true) ? 0 : -1;
239 } 226 }
240 227
241 int run_auto_test(TestType test_type) { 228 int run_auto_test(TestType test_type) {
242 assert(test_type != Standard); 229 assert(test_type != Standard);
243 230
244 SubAPIManager api_manager; 231 SubAPIManager api_manager;
245 api_manager.DisplayStatus(); 232 api_manager.DisplayStatus();
246 233
247 //////////////////////////////////// 234 ////////////////////////////////////
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 google::AllowCommandLineReparsing(); 333 google::AllowCommandLineReparsing();
347 google::ParseCommandLineFlags(&argc, &argv, true); 334 google::ParseCommandLineFlags(&argc, &argv, true);
348 335
349 if (FLAGS_automated) { 336 if (FLAGS_automated) {
350 return RunInAutomatedMode(); 337 return RunInAutomatedMode();
351 } 338 }
352 339
353 return RunInManualMode(); 340 return RunInManualMode();
354 } 341 }
355 #endif //#if !defined(WEBRTC_IOS) 342 #endif //#if !defined(WEBRTC_IOS)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698