Update reference indices according to updates in the RTP payload profile.

Update reference indices according to updates in the RTP payload profile.

https://tools.ietf.org/id/draft-ietf-payload-vp9-01.txt

BUG=chromium:500602
Committed: https://crrev.com/32df5efc6db394ff4c535c2049c079b8c0e31183
Cr-Commit-Position: refs/heads/master@{#10442}

[åsapersson, 2015-10-28 11:05:26]

Description was changed from

==========
Update reference indices according to updates in the RTP payload profile.

BUG=chromium:500602
==========

to

==========
Update reference indices according to updates in the RTP payload profile.

BUG=chromium:500602
==========

[åsapersson, 2015-10-28 11:05:26]

asapersson@webrtc.org changed reviewers:
+ stefan@webrtc.org

[åsapersson, 2015-10-28 12:19:16]

Description was changed from

==========
Update reference indices according to updates in the RTP payload profile.

BUG=chromium:500602
==========

to

==========
Update reference indices according to updates in the RTP payload profile.

https://tools.ietf.org/id/draft-ietf-payload-vp9-01.txt

BUG=chromium:500602
==========

[stefan-webrtc, 2015-10-28 12:35:52]

lgtm, one nit

https://codereview.webrtc.org/1406283008/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtp_format_vp9_unittest.cc (right):

https://codereview.webrtc.org/1406283008/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_format_vp9_unittest.cc:320: //     
P_DIFF:127, N:0
Shouldn't 127 be the second one?

[åsapersson, 2015-10-28 12:48:21]

https://codereview.webrtc.org/1406283008/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtp_format_vp9_unittest.cc (right):

https://codereview.webrtc.org/1406283008/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_format_vp9_unittest.cc:320: //     
P_DIFF:127, N:0
On 2015/10/28 12:35:52, stefan-webrtc (holmer) wrote:
> Shouldn't 127 be the second one?

For
1: p_diff = 1   => ref_picture_id = 1
2: p_diff = 3   => ref_picture_id = 127
3: p_diff = 127 => ref_picture_id = 3

[stefan-webrtc, 2015-10-28 13:04:48]

https://codereview.webrtc.org/1406283008/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtp_format_vp9_unittest.cc (right):

https://codereview.webrtc.org/1406283008/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_format_vp9_unittest.cc:320: //     
P_DIFF:127, N:0
On 2015/10/28 12:48:21, åsapersson wrote:
> On 2015/10/28 12:35:52, stefan-webrtc (holmer) wrote:
> > Shouldn't 127 be the second one?
> 
> For
> 1: p_diff = 1   => ref_picture_id = 1
> 2: p_diff = 3   => ref_picture_id = 127
> 3: p_diff = 127 => ref_picture_id = 3

Makes sense, my bad. Maybe you could express liens 307-312 in terms of
kMaxPictureId to clarify?

[åsapersson, 2015-10-28 13:55:24]

https://codereview.webrtc.org/1406283008/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtp_format_vp9_unittest.cc (right):

https://codereview.webrtc.org/1406283008/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_format_vp9_unittest.cc:320: //     
P_DIFF:127, N:0
On 2015/10/28 13:04:48, stefan-webrtc (holmer) wrote:
> On 2015/10/28 12:48:21, åsapersson wrote:
> > On 2015/10/28 12:35:52, stefan-webrtc (holmer) wrote:
> > > Shouldn't 127 be the second one?
> > 
> > For
> > 1: p_diff = 1   => ref_picture_id = 1
> > 2: p_diff = 3   => ref_picture_id = 127
> > 3: p_diff = 127 => ref_picture_id = 3
> 
> Makes sense, my bad. Maybe you could express liens 307-312 in terms of
> kMaxPictureId to clarify?

Updated comments.
And added a todo for max picture id used.

[åsapersson, 2015-10-29 07:47:51]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2015-10-29 07:47:51]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1406283008/#ps60001 (title:
"updated comments and added todo")

[commit-bot: I haz the power, 2015-10-29 07:48:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406283008/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406283008/60001

[commit-bot: I haz the power, 2015-10-29 08:45:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-29 08:45:56]

Patchset 4 (id:??) landed as
https://crrev.com/32df5efc6db394ff4c535c2049c079b8c0e31183
Cr-Commit-Position: refs/heads/master@{#10442}