Update reference indices according to updates in the RTP payload profile.

webrtc/modules/rtp_rtcp/source/rtp_format_vp9.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 77 matching lines @@
             hdr.spatial_idx == kNoSpatialIdx) ? 0 : 2;
   }
 }
 
 bool LayerInfoPresent(const RTPVideoHeaderVP9& hdr) {
   return LayerInfoLength(hdr) > 0;
 }
 
 // Reference indices:
 //
-//      +-+-+-+-+-+-+-+-+  -|           P=1,F=1: At least one reference index
-// P,F: | P_DIFF    |X|N|   .                    has to be specified.
-//      +-+-+-+-+-+-+-+-+   . up to 3 times
-// X:   |EXTENDED P_DIFF|   .               X=1: Extended P_DIFF is used (14
-//      +-+-+-+-+-+-+-+-+  -|                    bits). Else 6 bits are used.
-//                                          N=1: An additional P_DIFF follows
-//                                               current P_DIFF.
+//      +-+-+-+-+-+-+-+-+                P=1,F=1: At least one reference index
+// P,F: | P_DIFF      |N|  up to 3 times          has to be specified.
+//      +-+-+-+-+-+-+-+-+                    N=1: An additional P_DIFF follows
+//                                                current P_DIFF.
+//
 size_t RefIndicesLength(const RTPVideoHeaderVP9& hdr) {
   if (!hdr.inter_pic_predicted || !hdr.flexible_mode)
     return 0;
 
   RTC_DCHECK_GT(hdr.num_ref_pics, 0U);
   RTC_DCHECK_LE(hdr.num_ref_pics, kMaxVp9RefPics);
-  size_t length = 0;
-  for (size_t i = 0; i < hdr.num_ref_pics; ++i) {
-    length += hdr.pid_diff[i] > 0x3F ? 2 : 1;   // P_DIFF > 6 bits => extended
-  }
-  return length;
+  return hdr.num_ref_pics;
 }
 
 // Scalability structure (SS).
 //
 //      +-+-+-+-+-+-+-+-+
 // V:   | N_S |Y|  N_G  |
 //      +-+-+-+-+-+-+-+-+              -|
 // Y:   |     WIDTH     | (OPTIONAL)    .
 //      +               +               .
 //      |               | (OPTIONAL)    .
@@ skipping 104 matching lines @@
                     rtc::BitBufferWriter* writer) {
   if (vp9.flexible_mode) {
     return WriteLayerInfoFlexibleMode(vp9, writer);
   } else {
     return WriteLayerInfoNonFlexibleMode(vp9, writer);
   }
 }
 
 // Reference indices:
 //
-//      +-+-+-+-+-+-+-+-+  -|           P=1,F=1: At least one reference index
-// P,F: | P_DIFF    |X|N|   .                    has to be specified.
-//      +-+-+-+-+-+-+-+-+   . up to 3 times
-// X:   |EXTENDED P_DIFF|   .               X=1: Extended P_DIFF is used (14
-//      +-+-+-+-+-+-+-+-+  -|                    bits). Else 6 bits are used.
-//                                          N=1: An additional P_DIFF follows
-//                                               current P_DIFF.
+//      +-+-+-+-+-+-+-+-+                P=1,F=1: At least one reference index
+// P,F: | P_DIFF      |N|  up to 3 times          has to be specified.
+//      +-+-+-+-+-+-+-+-+                    N=1: An additional P_DIFF follows
+//                                                current P_DIFF.
+//
 bool WriteRefIndices(const RTPVideoHeaderVP9& vp9,
                      rtc::BitBufferWriter* writer) {
   if (!PictureIdPresent(vp9) ||
       vp9.num_ref_pics == 0 || vp9.num_ref_pics > kMaxVp9RefPics) {
     return false;
   }
   for (size_t i = 0; i < vp9.num_ref_pics; ++i) {
-    bool x_bit = (vp9.pid_diff[i] > 0x3F);
     bool n_bit = !(i == vp9.num_ref_pics - 1);
-    if (x_bit) {
-      RETURN_FALSE_ON_ERROR(writer->WriteBits(vp9.pid_diff[i] >> 8, 6));
-      RETURN_FALSE_ON_ERROR(writer->WriteBits(x_bit ? 1 : 0, 1));
-      RETURN_FALSE_ON_ERROR(writer->WriteBits(n_bit ? 1 : 0, 1));
-      RETURN_FALSE_ON_ERROR(writer->WriteUInt8(vp9.pid_diff[i]));
-    } else {
-      RETURN_FALSE_ON_ERROR(writer->WriteBits(vp9.pid_diff[i], 6));
-      RETURN_FALSE_ON_ERROR(writer->WriteBits(x_bit ? 1 : 0, 1));
-      RETURN_FALSE_ON_ERROR(writer->WriteBits(n_bit ? 1 : 0, 1));
-    }
+    RETURN_FALSE_ON_ERROR(writer->WriteBits(vp9.pid_diff[i], 7));
+    RETURN_FALSE_ON_ERROR(writer->WriteBits(n_bit ? 1 : 0, 1));
   }
   return true;
 }
 
 // Scalability structure (SS).
 //
 //      +-+-+-+-+-+-+-+-+
 // V:   | N_S |Y|  N_G  |
 //      +-+-+-+-+-+-+-+-+              -|
 // Y:   |     WIDTH     | (OPTIONAL)    .
@@ skipping 108 matching lines @@
 bool ParseLayerInfo(rtc::BitBuffer* parser, RTPVideoHeaderVP9* vp9) {
   if (vp9->flexible_mode) {
     return ParseLayerInfoFlexibleMode(parser, vp9);
   } else {
     return ParseLayerInfoNonFlexibleMode(parser, vp9);
   }
 }
 
 // Reference indices:
 //
-//      +-+-+-+-+-+-+-+-+  -|           P=1,F=1: At least one reference index
-// P,F: | P_DIFF    |X|N|   .                    has to be specified.
-//      +-+-+-+-+-+-+-+-+   . up to 3 times
-// X:   |EXTENDED P_DIFF|   .               X=1: Extended P_DIFF is used (14
-//      +-+-+-+-+-+-+-+-+  -|                    bits). Else 6 bits are used.
-//                                          N=1: An additional P_DIFF follows
-//                                               current P_DIFF.
+//      +-+-+-+-+-+-+-+-+                P=1,F=1: At least one reference index
+// P,F: | P_DIFF      |N|  up to 3 times          has to be specified.
+//      +-+-+-+-+-+-+-+-+                    N=1: An additional P_DIFF follows
+//                                                current P_DIFF.
+//
 bool ParseRefIndices(rtc::BitBuffer* parser, RTPVideoHeaderVP9* vp9) {
   if (vp9->picture_id == kNoPictureId)
     return false;
 
   vp9->num_ref_pics = 0;
   uint32_t n_bit;
   do {
     if (vp9->num_ref_pics == kMaxVp9RefPics)
       return false;
 
-    uint32_t p_diff, x_bit;
-    RETURN_FALSE_ON_ERROR(parser->ReadBits(&p_diff, 6));
-    RETURN_FALSE_ON_ERROR(parser->ReadBits(&x_bit, 1));
+    uint32_t p_diff;
+    RETURN_FALSE_ON_ERROR(parser->ReadBits(&p_diff, 7));
     RETURN_FALSE_ON_ERROR(parser->ReadBits(&n_bit, 1));
 
-    if (x_bit) {
-      // P_DIFF is 14 bits.
-      uint8_t ext_p_diff;
-      RETURN_FALSE_ON_ERROR(parser->ReadUInt8(&ext_p_diff));
-      p_diff = (p_diff << 8) + ext_p_diff;
-    }
-
     vp9->pid_diff[vp9->num_ref_pics] = p_diff;
     uint32_t scaled_pid = vp9->picture_id;
-    while (p_diff > scaled_pid) {
+    if (p_diff > scaled_pid) {
+      // TODO(asapersson): Max should correspond to the picture id of last wrap.
       scaled_pid += vp9->max_picture_id + 1;
     }
     vp9->ref_picture_id[vp9->num_ref_pics++] = scaled_pid - p_diff;
   } while (n_bit);
 
   return true;
 }
 
 // Scalability structure (SS).
 //
@@ skipping 154 matching lines @@
 //       0 1 2 3 4 5 6 7
 //      +-+-+-+-+-+-+-+-+
 //      |I|P|L|F|B|E|V|-| (REQUIRED)
 //      +-+-+-+-+-+-+-+-+
 // I:   |M| PICTURE ID  | (RECOMMENDED)
 //      +-+-+-+-+-+-+-+-+
 // M:   | EXTENDED PID  | (RECOMMENDED)
 //      +-+-+-+-+-+-+-+-+
 // L:   |  T  |U|  S  |D| (CONDITIONALLY RECOMMENDED)
 //      +-+-+-+-+-+-+-+-+                             -|
-// P,F: | P_DIFF    |X|N| (CONDITIONALLY RECOMMENDED)  .
-//      +-+-+-+-+-+-+-+-+                              . up to 3 times
-// X:   |EXTENDED P_DIFF|                              .
+// P,F: | P_DIFF      |N| (CONDITIONALLY RECOMMENDED)  . up to 3 times
 //      +-+-+-+-+-+-+-+-+                             -|
 // V:   | SS            |
 //      | ..            |
 //      +-+-+-+-+-+-+-+-+
 //
 // Payload descriptor for F = 0 (non-flexible mode)
 //       0 1 2 3 4 5 6 7
 //      +-+-+-+-+-+-+-+-+
 //      |I|P|L|F|B|E|V|-| (REQUIRED)
 //      +-+-+-+-+-+-+-+-+
@@ skipping 143 matching lines @@
   if (parsed_payload->payload_length == 0) {
     LOG(LS_ERROR) << "Failed parsing VP9 payload data.";
     return false;
   }
   parsed_payload->payload =
       payload + payload_length - parsed_payload->payload_length;
 
   return true;
 }
 }  // namespace webrtc