Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1406193002: Transport sequence number should be set also for retransmissions. (Closed)

Created:
5 years, 2 months ago by sprang_webrtc
Modified:
5 years, 2 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, mflodman, the sun, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Transport sequence number should be set also for retransmissions. This is a reland of https://codereview.webrtc.org/1385563005 which was reverted since the test was flaky. The reason was a race condition (in the test) and that NACK wasn't properly set up. BUG= Committed: https://crrev.com/861c55e58311383b7f4f61af463ddea53eb3f30f Cr-Commit-Position: refs/heads/master@{#10303}

Patch Set 1 #

Patch Set 2 : Don't hold lock while sending #

Patch Set 3 : Fixed race in setup of unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -38 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 2 4 chunks +103 lines, -36 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
sprang_webrtc
Let's re-land this. Test case fixed and verified for flakiness with gtest_parallell. PTAL
5 years, 2 months ago (2015-10-16 11:32:04 UTC) #2
stefan-webrtc
lgtm
5 years, 2 months ago (2015-10-16 11:36:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406193002/20001
5 years, 2 months ago (2015-10-16 11:37:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_tsan2 on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/7329)
5 years, 2 months ago (2015-10-16 13:03:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406193002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406193002/40001
5 years, 2 months ago (2015-10-16 13:18:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on ...
5 years, 2 months ago (2015-10-16 15:19:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406193002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406193002/40001
5 years, 2 months ago (2015-10-16 17:00:28 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-16 17:01:26 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 17:01:32 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/861c55e58311383b7f4f61af463ddea53eb3f30f
Cr-Commit-Position: refs/heads/master@{#10303}

Powered by Google App Engine
This is Rietveld 408576698