Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1385563005: Transport sequence number should be set also for retransmissions. (Closed)

Created:
5 years, 2 months ago by sprang_webrtc
Modified:
5 years, 2 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, mflodman, the sun, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Transport sequence number should be set also for retransmissions. When fetching a packet from the rtp packet history, cuased by a retransmission, the transport seq extension header is enabled but the sequence number is set to 0. A new transport seq should be assigned in this case. BUG= Committed: https://crrev.com/af4ced986bc62c263fbdb6eab68aef5c0d4e7c78 Cr-Commit-Position: refs/heads/master@{#10183}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -8 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 7 chunks +24 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sprang_webrtc
5 years, 2 months ago (2015-10-06 09:46:01 UTC) #2
stefan-webrtc
lgtm
5 years, 2 months ago (2015-10-06 10:54:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385563005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385563005/1
5 years, 2 months ago (2015-10-06 10:59:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 13:02:58 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 13:03:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af4ced986bc62c263fbdb6eab68aef5c0d4e7c78
Cr-Commit-Position: refs/heads/master@{#10183}

Powered by Google App Engine
This is Rietveld 408576698