Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issue 1404473005: Reland of Moving MediaStreamSignaling logic into PeerConnection. (Closed)

Created:
5 years, 2 months ago by Taylor Brandstetter
Modified:
5 years, 2 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Moving MediaStreamSignaling logic into PeerConnection. (patchset #1 id:1 of https://codereview.webrtc.org/1403633005/ ) Reason for reland: The original CL actually didn't break browser_tests; it was just a coincidence that it started failing. Original issue's description: > Revert of Moving MediaStreamSignaling logic into PeerConnection. (patchset #10 id:180001 of https://codereview.webrtc.org/1393563002/ ) > > Reason for revert: > Broke browser_tests on Mac. Still need to investigate the cause. > > Original issue's description: > > Moving MediaStreamSignaling logic into PeerConnection. > > > > This needs to happen because in the future, m-lines will be offered > > based on the set of RtpSenders/RtpReceivers, rather than the set of > > tracks that MediaStreamSignaling knows about. > > > > Besides that, MediaStreamSignaling was a "glue class" without > > a clearly defined role, so it going away is good for other > > reasons as well. > > > > Committed: https://crrev.com/97c392935411398b506861601c82e31d95c591f0 > > Cr-Commit-Position: refs/heads/master@{#10268} > > TBR=pthatcher@webrtc.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/fc648b6d934e936f4d9a32c813364b331536ec3b > Cr-Commit-Position: refs/heads/master@{#10269} TBR=pthatcher@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/ab9b2d1516cad017c6e0236c468934582530c965 Cr-Commit-Position: refs/heads/master@{#10277}

Patch Set 1 #

Patch Set 2 : Getting rid of unneeded RTC_DCHECK. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2996 lines, -3324 lines) Patch
M talk/app/webrtc/datachannel.h View 1 7 chunks +32 lines, -13 lines 0 comments Download
M talk/app/webrtc/datachannel.cc View 1 7 chunks +57 lines, -9 lines 0 comments Download
M talk/app/webrtc/datachannel_unittest.cc View 1 2 chunks +73 lines, -0 lines 0 comments Download
M talk/app/webrtc/mediastreamsignaling.h View 1 chunk +1 line, -376 lines 0 comments Download
M talk/app/webrtc/mediastreamsignaling.cc View 1 chunk +1 line, -997 lines 0 comments Download
D talk/app/webrtc/mediastreamsignaling_unittest.cc View 1 chunk +0 lines, -1341 lines 0 comments Download
M talk/app/webrtc/peerconnection.h View 1 7 chunks +221 lines, -34 lines 0 comments Download
M talk/app/webrtc/peerconnection.cc View 1 26 chunks +1044 lines, -104 lines 0 comments Download
M talk/app/webrtc/peerconnectionendtoend_unittest.cc View 1 1 chunk +32 lines, -0 lines 0 comments Download
M talk/app/webrtc/peerconnectionfactory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface_unittest.cc View 1 23 chunks +1002 lines, -20 lines 0 comments Download
M talk/app/webrtc/sctputils.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M talk/app/webrtc/sctputils.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M talk/app/webrtc/sctputils_unittest.cc View 1 2 chunks +18 lines, -1 line 0 comments Download
M talk/app/webrtc/statscollector.h View 1 3 chunks +6 lines, -4 lines 0 comments Download
M talk/app/webrtc/statscollector.cc View 1 22 chunks +48 lines, -48 lines 0 comments Download
M talk/app/webrtc/statscollector_unittest.cc View 1 32 chunks +67 lines, -58 lines 0 comments Download
M talk/app/webrtc/webrtcsession.h View 1 8 chunks +19 lines, -19 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 1 20 chunks +42 lines, -86 lines 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 1 115 chunks +285 lines, -135 lines 0 comments Download
M talk/app/webrtc/webrtcsessiondescriptionfactory.h View 1 6 chunks +8 lines, -18 lines 0 comments Download
M talk/app/webrtc/webrtcsessiondescriptionfactory.cc View 1 11 chunks +23 lines, -60 lines 0 comments Download
M talk/libjingle_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Taylor Brandstetter
Created Reland of Moving MediaStreamSignaling logic into PeerConnection.
5 years, 2 months ago (2015-10-14 00:24:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404473005/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404473005/280001
5 years, 2 months ago (2015-10-14 18:32:37 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:280001)
5 years, 2 months ago (2015-10-14 18:33:17 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 18:33:33 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab9b2d1516cad017c6e0236c468934582530c965
Cr-Commit-Position: refs/heads/master@{#10277}

Powered by Google App Engine
This is Rietveld 408576698