Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1404463003: Delete iSAC-fb from NetEq (Closed)

Created:
5 years, 2 months ago by hlundin-webrtc
Modified:
5 years, 2 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@remove-isac-fb
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete iSAC-fb from NetEq This is no longer used. Related code in the iSAC codec itself will be deleted a follow-up CL. BUG=4210 Committed: https://crrev.com/06b869f11a36c5abfb5e49a81ce7f88b2aa905d4 Cr-Commit-Position: refs/heads/master@{#10272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/timestamp_scaler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/timestamp_scaler_unittest.cc View 1 chunk +0 lines, -28 lines 0 comments Download

Depends on Patchset:

Issue 1404623002 Patch 20001

Dependent Patchsets:

Issue 1392173004 Patch 1
Issue 1392173004 Patch 20001

Messages

Total messages: 11 (4 generated)
hlundin-webrtc
PTAL.
5 years, 2 months ago (2015-10-13 13:30:06 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404463003/1
5 years, 2 months ago (2015-10-14 08:09:00 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-14 08:55:04 UTC) #6
kwiberg-webrtc
lgtm
5 years, 2 months ago (2015-10-14 10:37:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404463003/1
5 years, 2 months ago (2015-10-14 10:43:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 10:44:58 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 10:45:09 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/06b869f11a36c5abfb5e49a81ce7f88b2aa905d4
Cr-Commit-Position: refs/heads/master@{#10272}

Powered by Google App Engine
This is Rietveld 408576698