Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1392173004: Delete full-band mode from the iSAC codec (Closed)

Created:
5 years, 2 months ago by hlundin-webrtc
Modified:
5 years, 2 months ago
Reviewers:
*kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@remove-isac-fb-neteq
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete full-band mode from the iSAC codec This mode is no longer used. BUG=4210 Committed: https://crrev.com/bd7de0c6eff510f9ec95b13a16862ca55871c47d Cr-Commit-Position: refs/heads/master@{#10275}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove redundant DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -65 lines) Patch
M webrtc/modules/audio_coding/codecs/isac/audio_decoder_isac_t_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h View 1 2 chunks +1 line, -6 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/source/isac.c View 6 chunks +5 lines, -47 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/source/settings.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/source/structs.h View 1 chunk +2 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 1404463003 Patch 1

Messages

Total messages: 11 (4 generated)
hlundin-webrtc
👻
5 years, 2 months ago (2015-10-14 10:56:29 UTC) #3
kwiberg-webrtc
lgtm https://codereview.webrtc.org/1392173004/diff/1/webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h File webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h (right): https://codereview.webrtc.org/1392173004/diff/1/webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h#newcode183 webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h:183: RTC_DCHECK_LE(config.sample_rate_hz, 32000); Line 158 already verifies that this ...
5 years, 2 months ago (2015-10-14 11:07:35 UTC) #4
hlundin-webrtc
Remove redundant DCHECK
5 years, 2 months ago (2015-10-14 11:33:11 UTC) #5
hlundin-webrtc
https://codereview.webrtc.org/1392173004/diff/1/webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h File webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h (right): https://codereview.webrtc.org/1392173004/diff/1/webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h#newcode183 webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h:183: RTC_DCHECK_LE(config.sample_rate_hz, 32000); On 2015/10/14 11:07:35, kwiberg-webrtc wrote: > Line ...
5 years, 2 months ago (2015-10-14 11:33:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392173004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392173004/20001
5 years, 2 months ago (2015-10-14 11:33:54 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 13:05:57 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 13:06:10 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bd7de0c6eff510f9ec95b13a16862ca55871c47d
Cr-Commit-Position: refs/heads/master@{#10275}

Powered by Google App Engine
This is Rietveld 408576698