Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(35)

Issue 1403633005: Revert of Moving MediaStreamSignaling logic into PeerConnection. (Closed)

Created:
3 years, 11 months ago by Taylor Brandstetter
Modified:
3 years, 11 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Moving MediaStreamSignaling logic into PeerConnection. (patchset #10 id:180001 of https://codereview.webrtc.org/1393563002/ ) Reason for revert: Broke browser_tests on Mac. Still need to investigate the cause. Original issue's description: > Moving MediaStreamSignaling logic into PeerConnection. > > This needs to happen because in the future, m-lines will be offered > based on the set of RtpSenders/RtpReceivers, rather than the set of > tracks that MediaStreamSignaling knows about. > > Besides that, MediaStreamSignaling was a "glue class" without > a clearly defined role, so it going away is good for other > reasons as well. > > Committed: https://crrev.com/97c392935411398b506861601c82e31d95c591f0 > Cr-Commit-Position: refs/heads/master@{#10268} TBR=pthatcher@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/fc648b6d934e936f4d9a32c813364b331536ec3b Cr-Commit-Position: refs/heads/master@{#10269}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3337 lines, -3009 lines) Patch
M talk/app/webrtc/datachannel.h View 7 chunks +13 lines, -32 lines 0 comments Download
M talk/app/webrtc/datachannel.cc View 7 chunks +11 lines, -59 lines 0 comments Download
M talk/app/webrtc/datachannel_unittest.cc View 2 chunks +0 lines, -73 lines 0 comments Download
M talk/app/webrtc/mediastreamsignaling.h View 1 chunk +376 lines, -1 line 0 comments Download
M talk/app/webrtc/mediastreamsignaling.cc View 1 chunk +997 lines, -1 line 0 comments Download
A talk/app/webrtc/mediastreamsignaling_unittest.cc View 1 chunk +1341 lines, -0 lines 0 comments Download
M talk/app/webrtc/peerconnection.h View 7 chunks +34 lines, -221 lines 0 comments Download
M talk/app/webrtc/peerconnection.cc View 26 chunks +110 lines, -1050 lines 0 comments Download
M talk/app/webrtc/peerconnectionendtoend_unittest.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M talk/app/webrtc/peerconnectionfactory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M talk/app/webrtc/peerconnectioninterface_unittest.cc View 23 chunks +20 lines, -1002 lines 0 comments Download
M talk/app/webrtc/sctputils.h View 1 chunk +0 lines, -3 lines 0 comments Download
M talk/app/webrtc/sctputils.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M talk/app/webrtc/sctputils_unittest.cc View 2 chunks +1 line, -18 lines 0 comments Download
M talk/app/webrtc/statscollector.h View 3 chunks +4 lines, -6 lines 0 comments Download
M talk/app/webrtc/statscollector.cc View 22 chunks +50 lines, -50 lines 0 comments Download
M talk/app/webrtc/statscollector_unittest.cc View 32 chunks +58 lines, -67 lines 0 comments Download
M talk/app/webrtc/webrtcsession.h View 8 chunks +19 lines, -19 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 20 chunks +89 lines, -45 lines 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 115 chunks +135 lines, -285 lines 0 comments Download
M talk/app/webrtc/webrtcsessiondescriptionfactory.h View 6 chunks +18 lines, -8 lines 0 comments Download
M talk/app/webrtc/webrtcsessiondescriptionfactory.cc View 10 chunks +60 lines, -23 lines 0 comments Download
M talk/libjingle_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Taylor Brandstetter
Created Revert of Moving MediaStreamSignaling logic into PeerConnection.
3 years, 11 months ago (2015-10-13 23:41:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403633005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403633005/1
3 years, 11 months ago (2015-10-13 23:42:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2015-10-13 23:43:10 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fc648b6d934e936f4d9a32c813364b331536ec3b Cr-Commit-Position: refs/heads/master@{#10269}
3 years, 11 months ago (2015-10-13 23:43:30 UTC) #4
Taylor Brandstetter
3 years, 11 months ago (2015-10-14 00:24:07 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1404473005/ by deadbeef@webrtc.org.

The reason for reverting is: ..

Powered by Google App Engine
This is Rietveld 408576698