Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1401943002: Fix use of scaler in MediaCodecVideoEncoder (Closed)

Created:
5 years, 2 months ago by perkj_webrtc
Modified:
5 years, 2 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix use of scaler in MediaCodecVideoEncoder This bug fixes an issue introduced in https://codereview.webrtc.org/1396073003/ BUG=webrtc:5067 TEST= set new_bit_rate = 200 in MediaCodecVideoEncoder::SetRatesOnCodecThread and compile and run ApprtDemo R=magjed@webrtc.org Committed: https://crrev.com/ec93628e75fdb81f23635b39b5f3da846bcefd21 Cr-Commit-Position: refs/heads/master@{#10263}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M talk/app/webrtc/java/jni/androidmediaencoder_jni.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
perkj_webrtc
Please?
5 years, 2 months ago (2015-10-13 11:48:11 UTC) #2
magjed_webrtc
lgtm
5 years, 2 months ago (2015-10-13 12:03:37 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ec93628e75fdb81f23635b39b5f3da846bcefd21 Cr-Commit-Position: refs/heads/master@{#10263}
5 years, 2 months ago (2015-10-13 12:04:19 UTC) #4
perkj_webrtc
5 years, 2 months ago (2015-10-13 12:04:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ec93628e75fdb81f23635b39b5f3da846bcefd21 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698