Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 1396073003: Prepare MediaCodecVideoEncoder for surface textures. (Closed)

Created:
3 years, 11 months ago by perkj_webrtc
Modified:
3 years, 11 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Prepare MediaCodecVideoEncoder for surface textures. This make small refactorings to MediaVideoEncoder to prepare for adding support to encode from textures. The C++ layer does not have any functional changes. - Moves ResetEncoder to always work on the codec thread - Adds use of ThreadChecker. - Change Java MediaEncoder.Init to return true or false and introduce method getInputBuffers. - Add simple unit test for Java MediaCodecVideoEncoder. BUG=webrtc:4993 Committed: https://crrev.com/90754174d98d6b71fd4aaed897bd54980f7e59c4 Cr-Commit-Position: refs/heads/master@{#10250}

Patch Set 1 #

Patch Set 2 : Self review #

Total comments: 26

Patch Set 3 : Rebased #

Patch Set 4 : addressed comments #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -99 lines) Patch
A talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java View 1 2 3 1 chunk +95 lines, -0 lines 0 comments Download
M talk/app/webrtc/java/jni/androidmediaencoder_jni.cc View 1 2 3 4 23 chunks +118 lines, -72 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java View 1 2 3 4 9 chunks +31 lines, -27 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
perkj_webrtc
Please?
3 years, 11 months ago (2015-10-12 07:50:52 UTC) #2
magjed_webrtc
lgtm % nits https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java File talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java (right): https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java#newcode31 talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java:31: import android.opengl.EGL14; Not used: EGL14,GLES11Ext,GLES20. https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java#newcode91 ...
3 years, 11 months ago (2015-10-12 08:22:53 UTC) #3
perkj_webrtc
https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java File talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java (right): https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java#newcode31 talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java:31: import android.opengl.EGL14; On 2015/10/12 08:22:52, magjed_webrtc wrote: > Not ...
3 years, 11 months ago (2015-10-12 09:16:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396073003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396073003/80001
3 years, 11 months ago (2015-10-12 09:17:35 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
3 years, 11 months ago (2015-10-12 10:04:19 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2015-10-12 10:04:31 UTC) #9
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/90754174d98d6b71fd4aaed897bd54980f7e59c4
Cr-Commit-Position: refs/heads/master@{#10250}

Powered by Google App Engine
This is Rietveld 408576698