Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1399553003: Reland: Remove AudioTrackRenderer (Closed)

Created:
5 years, 2 months ago by the sun
Modified:
5 years, 2 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

- Remove AudioTrackRenderer. - Remove AddChannel/RemoveChannel from AudioRenderer interface. BUG=webrtc:4690 Committed: https://crrev.com/1c0bb386b67835feb5934f503dddfe0912bce3ac Cr-Commit-Position: refs/heads/master@{#10226} Committed: https://crrev.com/98c68865e715f693390209adb454ab3a5b6de332 Cr-Commit-Position: refs/heads/master@{#10235}

Patch Set 1 #

Patch Set 2 : Remove unused AudioTrackRenderer #

Patch Set 3 : remove files for real #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -153 lines) Patch
M talk/app/webrtc/audiotrackrenderer.h View 1 2 1 chunk +0 lines, -59 lines 0 comments Download
M talk/app/webrtc/audiotrackrenderer.cc View 1 2 1 chunk +0 lines, -49 lines 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 1 2 3 4 chunks +1 line, -15 lines 0 comments Download
M talk/libjingle.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M talk/media/base/audiorenderer.h View 1 chunk +0 lines, -14 lines 0 comments Download
M talk/media/base/fakemediaengine.h View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 1 2 3 2 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
the sun
5 years, 2 months ago (2015-10-08 15:59:10 UTC) #2
tommi
lgtm
5 years, 2 months ago (2015-10-08 18:47:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399553003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399553003/40001
5 years, 2 months ago (2015-10-08 18:48:11 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-08 19:49:49 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/1c0bb386b67835feb5934f503dddfe0912bce3ac Cr-Commit-Position: refs/heads/master@{#10226}
5 years, 2 months ago (2015-10-08 19:50:02 UTC) #7
torbjorng (webrtc)
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.webrtc.org/1393343003/ by torbjorng@webrtc.org. ...
5 years, 2 months ago (2015-10-08 20:10:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399553003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399553003/60001
5 years, 2 months ago (2015-10-09 09:40:54 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-09 10:27:44 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 10:27:51 UTC) #13
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/98c68865e715f693390209adb454ab3a5b6de332
Cr-Commit-Position: refs/heads/master@{#10235}

Powered by Google App Engine
This is Rietveld 408576698