Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: talk/media/webrtc/webrtcvoiceengine.cc

Issue 1399553003: Reland: Remove AudioTrackRenderer (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/media/base/fakemediaengine.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/media/webrtc/webrtcvoiceengine.cc
diff --git a/talk/media/webrtc/webrtcvoiceengine.cc b/talk/media/webrtc/webrtcvoiceengine.cc
index a10c6f8aec12330711daf19e9ad5fd1f3bae4f2b..4d74e915c51441b3a4d403531dc7a87eeaa877c6 100644
--- a/talk/media/webrtc/webrtcvoiceengine.cc
+++ b/talk/media/webrtc/webrtcvoiceengine.cc
@@ -1330,10 +1330,6 @@ class WebRtcVoiceMediaChannel::WebRtcVoiceChannelRenderer
RTC_DCHECK(renderer_ == renderer);
return;
}
-
- // TODO(xians): Remove AddChannel() call after Chrome turns on APM
- // in getUserMedia by default.
- renderer->AddChannel(channel_);
renderer->SetSink(this);
renderer_ = renderer;
}
@@ -1343,12 +1339,10 @@ class WebRtcVoiceMediaChannel::WebRtcVoiceChannelRenderer
// This method is called on the libjingle worker thread.
void Stop() {
rtc::CritScope lock(&lock_);
- if (renderer_ == NULL)
- return;
-
- renderer_->RemoveChannel(channel_);
- renderer_->SetSink(NULL);
- renderer_ = NULL;
+ if (renderer_ != NULL) {
+ renderer_->SetSink(NULL);
+ renderer_ = NULL;
+ }
}
// AudioRenderer::Sink implementation.
« no previous file with comments | « talk/media/base/fakemediaengine.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698