Make the WARN_UNUSED_RESULT macro match the Chromium one.

Make the WARN_UNUSED_RESULT macro match the Chromium one.

BUG=none

Committed: https://crrev.com/3402bcda563ae445d8f0dc9afbc17d32254e5d2e
Cr-Commit-Position: refs/heads/master@{#10259}

[dcheng, 2015-10-12 19:52:47]

dcheng@chromium.org changed reviewers:
+ jiayl@webrtc.org

[dcheng, 2015-10-12 19:52:47]

As an aside... can we somehow make it possible for Chrome engineers to make
WebRTC changes inside src/third_party/webrtc?

Some platforms (like Windows) have a non-trivial setup cost and a non-trivial
compile cost. In fact, when I tried fetch webrtc, it failed when it tried to
call setup_links.py... because it needs admin privileges. Getting a checkout of
WebRTC should not require that you be an admin.

[jiayl2, 2015-10-12 23:25:33]

On 2015/10/12 19:52:47, dcheng wrote:
> As an aside... can we somehow make it possible for Chrome engineers to make
> WebRTC changes inside src/third_party/webrtc?
> 
> Some platforms (like Windows) have a non-trivial setup cost and a non-trivial
> compile cost. In fact, when I tried fetch webrtc, it failed when it tried to
> call setup_links.py... because it needs admin privileges. Getting a checkout
of
> WebRTC should not require that you be an admin.

Added kjellander@.

[jiayl2, 2015-10-12 23:26:43]

lgtm rubber stamp

[dcheng, 2015-10-12 23:27:04]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2015-10-12 23:27:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1399313002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1399313002/1

[commit-bot: I haz the power, 2015-10-12 23:28:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-12 23:28:32]

Patchset 1 (id:??) landed as
https://crrev.com/3402bcda563ae445d8f0dc9afbc17d32254e5d2e
Cr-Commit-Position: refs/heads/master@{#10259}

[kjellander_chromium, 2015-10-13 06:56:07]

On 2015/10/12 19:52:47, dcheng wrote:
> As an aside... can we somehow make it possible for Chrome engineers to make
> WebRTC changes inside src/third_party/webrtc?

This is unfortunately not possible since our master repo at
https://chromium.googlesource.com/external/webrtc/ is not mirrored in Chrome.
src/third_party/webrtc is the webrtc/ subdirectory of our master repo, similar
to
src/third_party/libjingle/source/talk being the talk/ subdirectory.

We currently have no one working on this, and I believe the master bug for the
effort is: https://code.google.com/p/webrtc/issues/detail?id=3379
With that solved, it would be easy to change to what you suggest (I'd love to
have that too). My suggestion is you comment in the bug :)

> Some platforms (like Windows) have a non-trivial setup cost and a non-trivial
> compile cost. In fact, when I tried fetch webrtc, it failed when it tried to
> call setup_links.py... because it needs admin privileges. Getting a checkout
of
> WebRTC should not require that you be an admin.

This is an unfortunate side-effect of how we re-use Chromium's build toolchain.
See https://code.google.com/p/webrtc/issues/detail?id=4911 for a discussion
around this. I'm open to another solution if anyone can figure out one. It might
be fixed if I can find time to work on
https://code.google.com/p/webrtc/issues/detail?id=5006