webrtc/base/common.h - Issue 1399313002: Make the WARN_UNUSED_RESULT macro match the Chromium one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/common.h

Issue 1399313002: Make the WARN_UNUSED_RESULT macro match the Chromium one. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/base/common.h

diff --git a/webrtc/base/common.h b/webrtc/base/common.h

index e39b75daf431ed3cbe3b94897d72a0286412b278..e615c7669a40bd7e762e13c2cf55f4009464a78a 100644

--- a/webrtc/base/common.h

+++ b/webrtc/base/common.h

@@ -190,7 +190,7 @@ inline bool ImplicitCastToBool(bool result) { return result; }

// TODO(ajm): Hack to avoid multiple definitions until the base/ of webrtc and

// libjingle are merged.

#if !defined(WARN_UNUSED_RESULT)

-#if defined(__GNUC__)

+#if defined(__GNUC__) || defined(__clang__)

#define WARN_UNUSED_RESULT __attribute__((warn_unused_result))

#else

#define WARN_UNUSED_RESULT

« no previous file with comments | « no previous file | no next file » | no next file with comments »