Prepare MediaCodecVideoEncoder for surface textures.

Prepare MediaCodecVideoEncoder for surface textures.
This make small refactorings to MediaVideoEncoder to prepare for adding support to encode from textures. The C++ layer does not have any functional changes.
- Moves ResetEncoder to always work on the codec thread
- Adds use of ThreadChecker.
- Change Java MediaEncoder.Init to return true or false and introduce method getInputBuffers.
- Add simple unit test for Java MediaCodecVideoEncoder.

BUG=webrtc:4993
Committed: https://crrev.com/90754174d98d6b71fd4aaed897bd54980f7e59c4
Cr-Commit-Position: refs/heads/master@{#10250}

[perkj_webrtc, 2015-10-12 07:36:28]

perkj@webrtc.org changed reviewers:
+ magjed@webrtc.org

[perkj_webrtc, 2015-10-12 07:50:52]

Please?

[magjed_webrtc, 2015-10-12 08:22:53]

lgtm % nits

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/androidte...
File talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java
(right):

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/androidte...
talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java:31:
import android.opengl.EGL14;
Not used: EGL14,GLES11Ext,GLES20.

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/androidte...
talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java:91:
assertTrue(info.index >=0);
Missing space: >=0

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
File talk/app/webrtc/java/jni/androidmediaencoder_jni.cc (right):

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:110: //
ReleaseOnCodecThread() and InitEncodeOnCodecThread() in an attempt to
I was confused the first time I read this sentence, can you add something like
this to the beginning: // ResetCodecOnCodecThread() calls ReleaseOnCodecThread()
and InitEncodeOnCodecThread() in an attempt...

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:123: // encoder if |frame|
is a texture/byte buffer and the encoder is initialized
Remove comment about textures :)

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:125: bool
MaybeReconfigureEncoderOnCodecThread(const webrtc::VideoFrame& frame);
nit: From just reading bool MaybeReconfigureEncoder(), I would guess it returns
true if it reconfigures. Also, it's not clear what the purpose of the
reconfiguration is. Maybe rename to something like
UpdateEncoderConfigurationOnCodecThread()?

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:226: JNIEnv* jni,
VideoCodecType codecType) :
Revert this ws change

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:465: bool encode_status =
jni->CallBooleanMethod(
const bool

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:484: case
COLOR_FormatYUV420Planar:
Revert indentation change, it was correct before?

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:498: << "Unexpected double
InitEncode without Release";
ditto: Revert ws change

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:576: bool key_frame =
frame_types->front() != webrtc::kDeltaFrame;
const bool

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:577: bool encode_status =
true;
const bool encode_status = EncodeByteBufferOnCodecThread(jni, key_frame,
input_frame);

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:595: bool
reconfigure_due_to_size =
const bool

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/src/...
File talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java (right):

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java:210: boolean
initEncode(VideoCodecType type, int width, int height, int kbps, int fps) {
Add short comment about return value, e.g. "Returns true on success."

[perkj_webrtc, 2015-10-12 09:16:06]

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/androidte...
File talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java
(right):

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/androidte...
talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java:31:
import android.opengl.EGL14;
On 2015/10/12 08:22:52, magjed_webrtc wrote:
> Not used: EGL14,GLES11Ext,GLES20.

Done.

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/androidte...
talk/app/webrtc/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java:91:
assertTrue(info.index >=0);
On 2015/10/12 08:22:52, magjed_webrtc wrote:
> Missing space: >=0

Done.

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
File talk/app/webrtc/java/jni/androidmediaencoder_jni.cc (right):

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:110: //
ReleaseOnCodecThread() and InitEncodeOnCodecThread() in an attempt to
On 2015/10/12 08:22:53, magjed_webrtc wrote:
> I was confused the first time I read this sentence, can you add something like
> this to the beginning: // ResetCodecOnCodecThread() calls
ReleaseOnCodecThread()
> and InitEncodeOnCodecThread() in an attempt...

Done.

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:123: // encoder if |frame|
is a texture/byte buffer and the encoder is initialized
On 2015/10/12 08:22:53, magjed_webrtc wrote:
> Remove comment about textures :)

Done.

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:125: bool
MaybeReconfigureEncoderOnCodecThread(const webrtc::VideoFrame& frame);
On 2015/10/12 08:22:53, magjed_webrtc wrote:
> nit: From just reading bool MaybeReconfigureEncoder(), I would guess it
returns
> true if it reconfigures. Also, it's not clear what the purpose of the
> reconfiguration is. Maybe rename to something like
> UpdateEncoderConfigurationOnCodecThread()?

Acknowledged.

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:226: JNIEnv* jni,
VideoCodecType codecType) :
On 2015/10/12 08:22:53, magjed_webrtc wrote:
> Revert this ws change

Done.

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:465: bool encode_status =
jni->CallBooleanMethod(
On 2015/10/12 08:22:53, magjed_webrtc wrote:
> const bool

Done.

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:484: case
COLOR_FormatYUV420Planar:
On 2015/10/12 08:22:53, magjed_webrtc wrote:
> Revert indentation change, it was correct before?

Done.

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:498: << "Unexpected double
InitEncode without Release";
On 2015/10/12 08:22:53, magjed_webrtc wrote:
> ditto: Revert ws change

Done.

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:576: bool key_frame =
frame_types->front() != webrtc::kDeltaFrame;
On 2015/10/12 08:22:53, magjed_webrtc wrote:
> const bool

Done.

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:577: bool encode_status =
true;
On 2015/10/12 08:22:53, magjed_webrtc wrote:
> const bool encode_status = EncodeByteBufferOnCodecThread(jni, key_frame,
> input_frame);

Done.

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:595: bool
reconfigure_due_to_size =
On 2015/10/12 08:22:53, magjed_webrtc wrote:
> const bool

Done.

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/src/...
File talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java (right):

https://codereview.webrtc.org/1396073003/diff/20001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java:210: boolean
initEncode(VideoCodecType type, int width, int height, int kbps, int fps) {
On 2015/10/12 08:22:53, magjed_webrtc wrote:
> Add short comment about return value, e.g. "Returns true on success."

Done.

[perkj_webrtc, 2015-10-12 09:17:29]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2015-10-12 09:17:30]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1396073003/#ps80001 (title:
" ")

[commit-bot: I haz the power, 2015-10-12 09:17:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1396073003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1396073003/80001

[commit-bot: I haz the power, 2015-10-12 10:04:19]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-10-12 10:04:31]

Patchset 5 (id:??) landed as
https://crrev.com/90754174d98d6b71fd4aaed897bd54980f7e59c4
Cr-Commit-Position: refs/heads/master@{#10250}