Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1272)

Unified Diff: webrtc/modules/audio_processing/include/audio_processing.h

Issue 1394103003: Make the nonlinear beamformer steerable (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@highfreq
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/include/audio_processing.h
diff --git a/webrtc/modules/audio_processing/include/audio_processing.h b/webrtc/modules/audio_processing/include/audio_processing.h
index 318b2f89533652b6fd1ad896d269f78deb0d004d..60520162085c6a3e7487a813373743297effd55c 100644
--- a/webrtc/modules/audio_processing/include/audio_processing.h
+++ b/webrtc/modules/audio_processing/include/audio_processing.h
@@ -109,12 +109,19 @@ struct ExperimentalNs {
struct Beamforming {
Beamforming()
: enabled(false),
- array_geometry() {}
+ array_geometry(),
+ target_angle_radians(M_PI / 2.f) {}
The Sun (google.com) 2015/10/13 07:20:21 Use C++11 initialization?
aluebs-webrtc 2015/10/20 00:04:20 I am not sure what you are suggesting. What am I m
Beamforming(bool enabled, const std::vector<Point>& array_geometry)
+ : Beamforming(enabled, array_geometry, M_PI / 2.f) {}
+ Beamforming(bool enabled,
+ const std::vector<Point>& array_geometry,
+ float target_angle_radians)
: enabled(enabled),
- array_geometry(array_geometry) {}
+ array_geometry(array_geometry),
+ target_angle_radians(target_angle_radians) {}
const bool enabled;
const std::vector<Point> array_geometry;
+ const float target_angle_radians;
Andrew MacDonald 2015/10/14 22:12:31 We don't have any immediate use for exposing this
aluebs-webrtc 2015/10/20 00:04:20 Yes, I only surfaced it here to test it in audiopr
Andrew MacDonald 2015/10/20 03:00:08 I think it's probably worth it.
aluebs-webrtc 2015/10/21 01:41:40 Agreed.
};
// Use to enable intelligibility enhancer in audio processing. Must be provided

Powered by Google App Engine
This is Rietveld 408576698