Make the nonlinear beamformer steerable

webrtc/modules/audio_processing/include/audio_processing.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 91 matching lines @@
   ExperimentalNs() : enabled(false) {}
   explicit ExperimentalNs(bool enabled) : enabled(enabled) {}
   bool enabled;
 };
 
 // Use to enable beamforming. Must be provided through the constructor. It will
 // have no impact if used with AudioProcessing::SetExtraOptions().
 struct Beamforming {
   Beamforming()
       : enabled(false),
-        array_geometry() {}
+        array_geometry(),
+        target_angle_radians(M_PI / 2.f) {}

[The Sun (google.com), 2015/10/13 07:20:21]

Use C++11 initialization?

[aluebs-webrtc, 2015/10/20 00:04:20]

I am not sure what you are suggesting. What am I missing?

   Beamforming(bool enabled, const std::vector<Point>& array_geometry)
+      : Beamforming(enabled, array_geometry, M_PI / 2.f) {}
+  Beamforming(bool enabled,
+              const std::vector<Point>& array_geometry,
+              float target_angle_radians)
       : enabled(enabled),
-        array_geometry(array_geometry) {}
+        array_geometry(array_geometry),
+        target_angle_radians(target_angle_radians) {}
   const bool enabled;
   const std::vector<Point> array_geometry;
+  const float target_angle_radians;

[Andrew MacDonald, 2015/10/14 22:12:31]

We don't have any immediate use for exposing this in the AudioProcessing
interface. Should we hold off?

I suppose you want to be able to test it in audioproc_float, which is
justification enough :)

[aluebs-webrtc, 2015/10/20 00:04:20]

Yes, I only surfaced it here to test it in audioproc_float. But if you think it
doesn't make sense I can hold off with that.

[Andrew MacDonald, 2015/10/20 03:00:08]

I think it's probably worth it.

[aluebs-webrtc, 2015/10/21 01:41:40]

Agreed.

 };
 
 // Use to enable intelligibility enhancer in audio processing. Must be provided
 // though the constructor. It will have no impact if used with
 // AudioProcessing::SetExtraOptions().
 //
 // Note: If enabled and the reverse stream has more than one output channel,
 // the reverse stream will become an upmixed mono signal.
 struct Intelligibility {
   Intelligibility() : enabled(false) {}
@@ skipping 801 matching lines @@
   // This does not impact the size of frames passed to |ProcessStream()|.
   virtual int set_frame_size_ms(int size) = 0;
   virtual int frame_size_ms() const = 0;
 
  protected:
   virtual ~VoiceDetection() {}
 };
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_AUDIO_PROCESSING_INCLUDE_AUDIO_PROCESSING_H_