Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1391403004: Android: Put common native VideoFrameBuffer implementation in androidvideocapturer_jni (Closed)

Created:
5 years, 2 months ago by magjed_webrtc
Modified:
5 years, 2 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Put common native VideoFrameBuffer implementation in native_handle_impl.cc BUG=webrtc:4993 R=perkj@webrtc.org Committed: https://crrev.com/60472216da0644b49ed5f9fa51c51d4874afafa7 Cr-Commit-Position: refs/heads/master@{#10248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -57 lines) Patch
M talk/app/webrtc/java/jni/androidvideocapturer_jni.cc View 2 chunks +1 line, -29 lines 0 comments Download
M talk/app/webrtc/java/jni/native_handle_impl.h View 2 chunks +16 lines, -0 lines 0 comments Download
M talk/app/webrtc/java/jni/native_handle_impl.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M talk/app/webrtc/java/jni/surfacetexturehelper_jni.h View 1 chunk +0 lines, -1 line 0 comments Download
M talk/app/webrtc/java/jni/surfacetexturehelper_jni.cc View 2 chunks +4 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
magjed_webrtc
perkj - Please take a look.
5 years, 2 months ago (2015-10-09 16:46:52 UTC) #2
perkj_webrtc
On 2015/10/09 16:46:52, magjed_webrtc wrote: > perkj - Please take a look. lgtm
5 years, 2 months ago (2015-10-11 14:57:36 UTC) #3
magjed_webrtc
Committed patchset #1 (id:1) manually as 60472216da0644b49ed5f9fa51c51d4874afafa7 (presubmit successful).
5 years, 2 months ago (2015-10-12 07:36:22 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/60472216da0644b49ed5f9fa51c51d4874afafa7 Cr-Commit-Position: refs/heads/master@{#10248}
5 years, 2 months ago (2015-10-12 07:36:24 UTC) #5
magjed_webrtc
5 years, 2 months ago (2015-10-12 09:25:14 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1389283003/ by magjed@webrtc.org.

The reason for reverting is: Crashes on AppRTCDemo disconnect.

Powered by Google App Engine
This is Rietveld 408576698