Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1389283003: Revert of Android: Put common native VideoFrameBuffer implementation in androidvideocapturer_jni (Closed)

Created:
5 years, 2 months ago by magjed_webrtc
Modified:
5 years, 2 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Android: Put common native VideoFrameBuffer implementation in androidvideocapturer_jni (patchset #1 id:1 of https://codereview.webrtc.org/1391403004/ ) Reason for revert: Crashes on AppRTCDemo disconnect Original issue's description: > Android: Put common native VideoFrameBuffer implementation in native_handle_impl.cc > > BUG=webrtc:4993 > R=perkj@webrtc.org > > Committed: https://crrev.com/60472216da0644b49ed5f9fa51c51d4874afafa7 > Cr-Commit-Position: refs/heads/master@{#10248} TBR=perkj@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4993 Committed: https://crrev.com/962c26bfd6c3eb3cf7402daaab89404ae38dd534 Cr-Commit-Position: refs/heads/master@{#10249}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -41 lines) Patch
M talk/app/webrtc/java/jni/androidvideocapturer_jni.cc View 2 chunks +29 lines, -1 line 0 comments Download
M talk/app/webrtc/java/jni/native_handle_impl.h View 2 chunks +0 lines, -16 lines 0 comments Download
M talk/app/webrtc/java/jni/native_handle_impl.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M talk/app/webrtc/java/jni/surfacetexturehelper_jni.h View 1 chunk +1 line, -0 lines 0 comments Download
M talk/app/webrtc/java/jni/surfacetexturehelper_jni.cc View 2 chunks +27 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
magjed_webrtc
Created Revert of Android: Put common native VideoFrameBuffer implementation in androidvideocapturer_jni
5 years, 2 months ago (2015-10-12 09:25:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1389283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1389283003/1
5 years, 2 months ago (2015-10-12 09:25:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 09:26:07 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/962c26bfd6c3eb3cf7402daaab89404ae38dd534 Cr-Commit-Position: refs/heads/master@{#10249}
5 years, 2 months ago (2015-10-12 09:26:52 UTC) #4
magjed_webrtc
5 years, 2 months ago (2015-10-12 13:53:07 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1397373002/ by magjed@webrtc.org.

The reason for reverting is: Nothing wrong with the original CL, the bug was in
rtc::Bind(), which is fixed now (https://codereview.webrtc.org/1403683004/)..

Powered by Google App Engine
This is Rietveld 408576698