Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1387243002: GN: Port frame_analyzer and rgba_to_i420_converter targets (Closed)

Created:
5 years, 2 months ago by kjellander_webrtc
Modified:
5 years, 2 months ago
Reviewers:
tfarina, phoglund
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Port frame_analyzer and rgba_to_i420_converter targets Original patch by tfarina@chromium.org at https://webrtc-codereview.appspot.com/42999004/ BUG=chromium:461019, webrtc:4504 TESTED=Tested on Linux with the following command lines: $ gn gen/out/Debug --args='is_debug=true build_with_chromium=false' $ ninja -C out/Debug frame_analyzer rgba_to_i420_converter Also successfully compiled from a Chromium checkout using the steps in webrtc:4504. R=tfarina@chromium.org Committed: https://crrev.com/67bcb609a33a551687e382d29c673bcb27fe42a4 Cr-Commit-Position: refs/heads/master@{#10193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -2 lines) Patch
M webrtc/tools/BUILD.gn View 1 chunk +38 lines, -1 line 0 comments Download
M webrtc/tools/frame_analyzer/video_quality_analysis.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/tools/frame_analyzer/video_quality_analysis.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/tools/internal_tools.gyp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
kjellander_webrtc
Cleaning up old issues... and this one seems to have resolved itself by just waiting ...
5 years, 2 months ago (2015-10-06 21:38:31 UTC) #2
tfarina
Happy this works now. Assuming you tested this on Chromium as well and it worked ...
5 years, 2 months ago (2015-10-07 01:05:00 UTC) #3
kjellander_webrtc
Committed patchset #1 (id:1) manually as 67bcb609a33a551687e382d29c673bcb27fe42a4 (presubmit successful).
5 years, 2 months ago (2015-10-07 06:43:13 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 06:43:16 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67bcb609a33a551687e382d29c673bcb27fe42a4
Cr-Commit-Position: refs/heads/master@{#10193}

Powered by Google App Engine
This is Rietveld 408576698