Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1386353003: Fix minor GYP error in webrtc/tools/internal_tools.gyp (Closed)

Created:
5 years, 2 months ago by kjellander_webrtc
Modified:
5 years, 2 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix minor GYP error in webrtc/tools/internal_tools.gyp It seems 'deps' is similar to 'dependencies' for the ninja and make generators in GYP, but some generators does not support it. Better use the correct key. This was introduced in https://codereview.webrtc.org/1387243002/ TBR=phoglund@webrtc.org Committed: https://crrev.com/78543284d0010efa4270ff9c102b673593c4827b Cr-Commit-Position: refs/heads/master@{#10200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/tools/internal_tools.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
kjellander_webrtc
5 years, 2 months ago (2015-10-07 12:51:23 UTC) #2
kjellander_webrtc
Committed patchset #1 (id:1) manually as 78543284d0010efa4270ff9c102b673593c4827b (presubmit successful).
5 years, 2 months ago (2015-10-07 12:51:47 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 12:51:53 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78543284d0010efa4270ff9c102b673593c4827b
Cr-Commit-Position: refs/heads/master@{#10200}

Powered by Google App Engine
This is Rietveld 408576698