Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1383563003: jni/native_handle_impl.h: Move implementation into .cc file (Closed)

Created:
5 years, 2 months ago by magjed_webrtc
Modified:
5 years, 2 months ago
Reviewers:
hbos
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

jni/native_handle_impl.h: Move implementation into .cc file BUG=webrtc:4993 R=hbos@webrtc.org Committed: https://crrev.com/6781ea49a8e6b4ef737097ee0e35fd4dbc00cb07 Cr-Commit-Position: refs/heads/master@{#10147}

Patch Set 1 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -42 lines) Patch
M talk/app/webrtc/java/jni/native_handle_impl.h View 3 chunks +8 lines, -20 lines 3 comments Download
A + talk/app/webrtc/java/jni/native_handle_impl.cc View 1 chunk +25 lines, -22 lines 0 comments Download
M talk/libjingle.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
magjed_webrtc
hbos - Please take a look.
5 years, 2 months ago (2015-10-02 08:27:43 UTC) #3
hbos
https://codereview.webrtc.org/1383563003/diff/20001/talk/app/webrtc/java/jni/native_handle_impl.h File talk/app/webrtc/java/jni/native_handle_impl.h (right): https://codereview.webrtc.org/1383563003/diff/20001/talk/app/webrtc/java/jni/native_handle_impl.h#newcode44 talk/app/webrtc/java/jni/native_handle_impl.h:44: int GetTextureId(); Make getters const?
5 years, 2 months ago (2015-10-02 08:58:30 UTC) #4
magjed_webrtc
https://codereview.webrtc.org/1383563003/diff/20001/talk/app/webrtc/java/jni/native_handle_impl.h File talk/app/webrtc/java/jni/native_handle_impl.h (right): https://codereview.webrtc.org/1383563003/diff/20001/talk/app/webrtc/java/jni/native_handle_impl.h#newcode44 talk/app/webrtc/java/jni/native_handle_impl.h:44: int GetTextureId(); On 2015/10/02 08:58:30, hbos wrote: > Make ...
5 years, 2 months ago (2015-10-02 09:35:12 UTC) #5
hbos
lgtm https://codereview.webrtc.org/1383563003/diff/20001/talk/app/webrtc/java/jni/native_handle_impl.h File talk/app/webrtc/java/jni/native_handle_impl.h (right): https://codereview.webrtc.org/1383563003/diff/20001/talk/app/webrtc/java/jni/native_handle_impl.h#newcode44 talk/app/webrtc/java/jni/native_handle_impl.h:44: int GetTextureId(); On 2015/10/02 09:35:12, magjed_webrtc wrote: > ...
5 years, 2 months ago (2015-10-02 11:02:58 UTC) #6
magjed_webrtc
Committed patchset #1 (id:20001) manually as 6781ea49a8e6b4ef737097ee0e35fd4dbc00cb07 (presubmit successful).
5 years, 2 months ago (2015-10-02 11:56:20 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 11:56:28 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6781ea49a8e6b4ef737097ee0e35fd4dbc00cb07
Cr-Commit-Position: refs/heads/master@{#10147}

Powered by Google App Engine
This is Rietveld 408576698