jni/native_handle_impl.h: Move implementation into .cc file

talk/app/webrtc/java/jni/native_handle_impl.h

 /*
  * libjingle
  * Copyright 2015 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 11 matching lines @@
  * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
  * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
  * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
  * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  *
  */
 
 #ifndef TALK_APP_WEBRTC_JAVA_JNI_NATIVE_HANDLE_IMPL_H_
 #define TALK_APP_WEBRTC_JAVA_JNI_NATIVE_HANDLE_IMPL_H_
 
-#include "webrtc/base/checks.h"
+#include <jni.h>
+
 #include "webrtc/common_video/interface/video_frame_buffer.h"
 
 namespace webrtc_jni {
 
 // Wrapper for texture object.
 class NativeHandleImpl {
  public:
-  NativeHandleImpl() : texture_object_(NULL), texture_id_(-1) {}
+  NativeHandleImpl();
 
-  void* GetHandle() {
-    return texture_object_;
-  }
-  int GetTextureId() {
-    return texture_id_;
-  }
-  void SetTextureObject(void *texture_object, int texture_id) {
-    texture_object_ = reinterpret_cast<jobject>(texture_object);
-    texture_id_ = texture_id;
-  }
+  void* GetHandle();
+  int GetTextureId();

[hbos, 2015/10/02 08:58:30]

Make getters const?

[magjed_webrtc, 2015/10/02 09:35:12]

I don't want to make any unrelated changes in this CL. Just a pure code move
into the .cc file.

[hbos, 2015/10/02 11:02:58]

http://f.tqn.com/y/webtrends/1/L/G/D/-/-/Okay_guy.jpg

+  void SetTextureObject(void* texture_object, int texture_id);
 
  private:
   jobject texture_object_;
   int32_t texture_id_;
 };
 
 class JniNativeHandleBuffer : public webrtc::NativeHandleBuffer {
  public:
-  JniNativeHandleBuffer(void* native_handle, int width, int height)
-      : NativeHandleBuffer(native_handle, width, height) {}
+  JniNativeHandleBuffer(void* native_handle, int width, int height);
 
   // TODO(pbos): Override destructor to release native handle, at the moment the
   // native handle is not released based on refcount.
 
  private:
-  rtc::scoped_refptr<VideoFrameBuffer> NativeToI420Buffer() override {
-    // TODO(pbos): Implement before using this in the encoder pipeline (or
-    // remove the RTC_CHECK() in VideoCapture).
-    RTC_NOTREACHED();
-    return nullptr;
-  }
+  rtc::scoped_refptr<webrtc::VideoFrameBuffer> NativeToI420Buffer() override;
 };
 
 }  // namespace webrtc_jni
 
 #endif  // TALK_APP_WEBRTC_JAVA_JNI_NATIVE_HANDLE_IMPL_H_