Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1383283005: Revert of Collecting encode_time_ms for each frame (Closed)

Created:
5 years, 2 months ago by kjellander_webrtc
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, andresp, peah-webrtc, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Collecting encode_time_ms for each frame (patchset #13 id:220001 of https://codereview.webrtc.org/1374233002/ ) Reason for revert: Breaks EndToEndTest.AssignsTransportSequenceNumbers in video_engine_tests on several bots: http://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/5507 http://build.chromium.org/p/client.webrtc/builders/Mac64%20Debug/builds/4815 http://build.chromium.org/p/client.webrtc/builders/Win%20SyzyASan/builds/3272 http://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/4414 It seems very unfortunate that it breaks on _exactly_ the bot configs that aren't covered by the CQ trybots. Original issue's description: > Collecting encode_time_ms for each frame. > > Also, in Sample struct, replacing double with the original type. > It makes more sense to save the original data as truthful as possible, and then > convert it to double later if necessary (in the plot script). > > Committed: https://crrev.com/092b13384e57b33e2003d9736dfa1f491e76f938 > Cr-Commit-Position: refs/heads/master@{#10184} TBR=sprang@webrtc.org,pbos@webrtc.org,mflodman@webrtc.org,asapersson@webrtc.org,ivica@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/810447972425e890bc7911af27f894b86e9b7e6f Cr-Commit-Position: refs/heads/master@{#10185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -93 lines) Patch
M webrtc/video/full_stack_plot.py View 2 chunks +9 lines, -11 lines 0 comments Download
M webrtc/video/video_capture_input.h View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/video/video_capture_input.cc View 3 chunks +6 lines, -13 lines 0 comments Download
M webrtc/video/video_capture_input_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_quality_test.cc View 7 chunks +27 lines, -52 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_send_stream.h View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kjellander_webrtc
Created Revert of Collecting encode_time_ms for each frame
5 years, 2 months ago (2015-10-06 18:33:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1383283005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1383283005/1
5 years, 2 months ago (2015-10-06 18:34:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 18:34:15 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/810447972425e890bc7911af27f894b86e9b7e6f Cr-Commit-Position: refs/heads/master@{#10185}
5 years, 2 months ago (2015-10-06 18:34:22 UTC) #4
ivica
5 years, 2 months ago (2015-10-07 09:42:51 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1390163002/ by ivica@webrtc.org.

The reason for reverting is: The reverted commit didn't affect the tests, but
the one before: https://codereview.webrtc.org/1385563005/

I've run the test that was failing
(EndToEndTest.AssignsTransportSequenceNumbers) locally multiple times, and it
works fine (finishes successfully in 150-170ms)..

Powered by Google App Engine
This is Rietveld 408576698