| Index: webrtc/video/video_quality_test.cc
|
| diff --git a/webrtc/video/video_quality_test.cc b/webrtc/video/video_quality_test.cc
|
| index c0f5754d0c48f92fefd879a43ee6f14cfaec2cec..c452e11895f082f30788a3d30503da1e81d92abc 100644
|
| --- a/webrtc/video/video_quality_test.cc
|
| +++ b/webrtc/video/video_quality_test.cc
|
| @@ -42,16 +42,16 @@
|
| public Transport,
|
| public VideoRenderer,
|
| public VideoCaptureInput,
|
| - public EncodedFrameObserver,
|
| - public EncodingTimeObserver {
|
| + public EncodedFrameObserver {
|
| public:
|
| - VideoAnalyzer(Transport* transport,
|
| + VideoAnalyzer(VideoCaptureInput* input,
|
| + Transport* transport,
|
| const std::string& test_label,
|
| double avg_psnr_threshold,
|
| double avg_ssim_threshold,
|
| int duration_frames,
|
| FILE* graph_data_output_file)
|
| - : input_(nullptr),
|
| + : input_(input),
|
| transport_(transport),
|
| receiver_(nullptr),
|
| send_stream_(nullptr),
|
| @@ -123,12 +123,6 @@
|
| return receiver_->DeliverPacket(media_type, packet, length, packet_time);
|
| }
|
|
|
| - // EncodingTimeObserver.
|
| - void OnReportEncodedTime(int64_t ntp_time_ms, int encode_time_ms) override {
|
| - rtc::CritScope crit(&comparison_lock_);
|
| - samples_encode_time_ms_[ntp_time_ms] = encode_time_ms;
|
| - }
|
| -
|
| void IncomingCapturedFrame(const VideoFrame& video_frame) override {
|
| VideoFrame copy = video_frame;
|
| copy.set_timestamp(copy.ntp_time_ms() * 90);
|
| @@ -285,31 +279,31 @@
|
| };
|
|
|
| struct Sample {
|
| - Sample(int dropped,
|
| - int64_t input_time_ms,
|
| - int64_t send_time_ms,
|
| - int64_t recv_time_ms,
|
| - int64_t render_time_ms,
|
| - size_t encoded_frame_size,
|
| + Sample(double dropped,
|
| + double input_time_ms,
|
| + double send_time_ms,
|
| + double recv_time_ms,
|
| + double encoded_frame_size,
|
| double psnr,
|
| - double ssim)
|
| + double ssim,
|
| + double render_time_ms)
|
| : dropped(dropped),
|
| input_time_ms(input_time_ms),
|
| send_time_ms(send_time_ms),
|
| recv_time_ms(recv_time_ms),
|
| - render_time_ms(render_time_ms),
|
| encoded_frame_size(encoded_frame_size),
|
| psnr(psnr),
|
| - ssim(ssim) {}
|
| -
|
| - int dropped;
|
| - int64_t input_time_ms;
|
| - int64_t send_time_ms;
|
| - int64_t recv_time_ms;
|
| - int64_t render_time_ms;
|
| - size_t encoded_frame_size;
|
| + ssim(ssim),
|
| + render_time_ms(render_time_ms) {}
|
| +
|
| + double dropped;
|
| + double input_time_ms;
|
| + double send_time_ms;
|
| + double recv_time_ms;
|
| + double encoded_frame_size;
|
| double psnr;
|
| double ssim;
|
| + double render_time_ms;
|
| };
|
|
|
| void AddFrameComparison(const VideoFrame& reference,
|
| @@ -471,8 +465,8 @@
|
| if (graph_data_output_file_) {
|
| samples_.push_back(
|
| Sample(comparison.dropped, input_time_ms, comparison.send_time_ms,
|
| - comparison.recv_time_ms, comparison.render_time_ms,
|
| - comparison.encoded_frame_size, psnr, ssim));
|
| + comparison.recv_time_ms, comparison.encoded_frame_size, psnr,
|
| + ssim, comparison.render_time_ms));
|
| }
|
| psnr_.AddSample(psnr);
|
| ssim_.AddSample(ssim);
|
| @@ -518,39 +512,21 @@
|
| "input_time_ms "
|
| "send_time_ms "
|
| "recv_time_ms "
|
| - "render_time_ms "
|
| "encoded_frame_size "
|
| "psnr "
|
| "ssim "
|
| - "encode_time_ms\n");
|
| - int missing_encode_time_samples = 0;
|
| + "render_time_ms\n");
|
| for (const Sample& sample : samples_) {
|
| - auto it = samples_encode_time_ms_.find(sample.input_time_ms);
|
| - int encode_time_ms;
|
| - if (it != samples_encode_time_ms_.end()) {
|
| - encode_time_ms = it->second;
|
| - } else {
|
| - ++missing_encode_time_samples;
|
| - encode_time_ms = -1;
|
| - }
|
| - fprintf(out, "%d %" PRId64 " %" PRId64 " %" PRId64 " %" PRId64 " %" PRIuS
|
| - " %lf %lf %d\n",
|
| - sample.dropped, sample.input_time_ms, sample.send_time_ms,
|
| - sample.recv_time_ms, sample.render_time_ms,
|
| + fprintf(out, "%lf %lf %lf %lf %lf %lf %lf %lf\n", sample.dropped,
|
| + sample.input_time_ms, sample.send_time_ms, sample.recv_time_ms,
|
| sample.encoded_frame_size, sample.psnr, sample.ssim,
|
| - encode_time_ms);
|
| - }
|
| - if (missing_encode_time_samples) {
|
| - fprintf(stderr,
|
| - "Warning: Missing encode_time_ms samples for %d frame(s).\n",
|
| - missing_encode_time_samples);
|
| + sample.render_time_ms);
|
| }
|
| }
|
|
|
| const std::string test_label_;
|
| FILE* const graph_data_output_file_;
|
| std::vector<Sample> samples_ GUARDED_BY(comparison_lock_);
|
| - std::map<int64_t, int> samples_encode_time_ms_ GUARDED_BY(comparison_lock_);
|
| test::Statistics sender_time_ GUARDED_BY(comparison_lock_);
|
| test::Statistics receiver_time_ GUARDED_BY(comparison_lock_);
|
| test::Statistics psnr_ GUARDED_BY(comparison_lock_);
|
| @@ -761,7 +737,7 @@
|
| static_cast<uint8_t>(params.common.tl_discard_threshold), 0);
|
| test::DirectTransport recv_transport(params.pipe);
|
| VideoAnalyzer analyzer(
|
| - &send_transport, params.analyzer.test_label,
|
| + nullptr, &send_transport, params.analyzer.test_label,
|
| params.analyzer.avg_psnr_threshold, params.analyzer.avg_ssim_threshold,
|
| params.analyzer.test_durations_secs * params.common.fps,
|
| graph_data_output_file);
|
| @@ -775,7 +751,6 @@
|
| recv_transport.SetReceiver(sender_call_->Receiver());
|
|
|
| SetupFullStack(params, &analyzer, &recv_transport);
|
| - send_config_.encoding_time_observer = &analyzer;
|
| receive_configs_[0].renderer = &analyzer;
|
| for (auto& config : receive_configs_)
|
| config.pre_decode_callback = &analyzer;
|
|
|