Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1383223002: In rampup tests, set start time when starting poller thread. (Closed)

Created:
5 years, 2 months ago by sprang_webrtc
Modified:
5 years, 2 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

In rampup tests, set start time when starting poller thread. This should avoid perf change caused by https://codereview.webrtc.org/1378303004 BUG=539257 R=stefan@webrtc.org Committed: https://crrev.com/f3a7c9d732bcb4ed59323d78f5e521615a46fdc2 Cr-Commit-Position: refs/heads/master@{#10168}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M webrtc/video/rampup_tests.cc View 1 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
sprang_webrtc
5 years, 2 months ago (2015-10-05 08:53:05 UTC) #2
stefan-webrtc
lgtm. consider fixing nit. https://codereview.webrtc.org/1383223002/diff/1/webrtc/video/rampup_tests.cc File webrtc/video/rampup_tests.cc (right): https://codereview.webrtc.org/1383223002/diff/1/webrtc/video/rampup_tests.cc#newcode58 webrtc/video/rampup_tests.cc:58: test_start_ms_(0), I'd prefer initializing to ...
5 years, 2 months ago (2015-10-05 08:54:55 UTC) #3
sprang_webrtc
https://codereview.webrtc.org/1383223002/diff/1/webrtc/video/rampup_tests.cc File webrtc/video/rampup_tests.cc (right): https://codereview.webrtc.org/1383223002/diff/1/webrtc/video/rampup_tests.cc#newcode58 webrtc/video/rampup_tests.cc:58: test_start_ms_(0), On 2015/10/05 08:54:55, stefan-webrtc (holmer) wrote: > I'd ...
5 years, 2 months ago (2015-10-05 09:46:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1383223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1383223002/20001
5 years, 2 months ago (2015-10-05 09:46:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 2 months ago (2015-10-05 11:46:52 UTC) #9
sprang_webrtc
Committed patchset #2 (id:20001) manually as f3a7c9d732bcb4ed59323d78f5e521615a46fdc2 (presubmit successful).
5 years, 2 months ago (2015-10-05 12:03:35 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 12:03:40 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f3a7c9d732bcb4ed59323d78f5e521615a46fdc2
Cr-Commit-Position: refs/heads/master@{#10168}

Powered by Google App Engine
This is Rietveld 408576698