Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 1378303004: Avoid race in RampUpTest (Closed)

Created:
5 years, 2 months ago by sprang_webrtc
Modified:
5 years, 2 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Avoid race in RampUpTest Poller thread is currently started in the constructor, so the first call to PollStats() may happen even before the streams have been configured. This will blow up on RTC_DCHECK_GT(expected_bitrate_bps_, 0); Thread should instead be started on PerformTest() call. BUG= Committed: https://crrev.com/a050e982b02b2faf59202a71b86a70328f372e97 Cr-Commit-Position: refs/heads/master@{#10149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/video/rampup_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sprang_webrtc
5 years, 2 months ago (2015-10-02 11:33:56 UTC) #2
stefan-webrtc
lgtm, thanks for fixing
5 years, 2 months ago (2015-10-02 12:57:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378303004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378303004/1
5 years, 2 months ago (2015-10-02 12:57:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 13:51:59 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 13:52:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a050e982b02b2faf59202a71b86a70328f372e97
Cr-Commit-Position: refs/heads/master@{#10149}

Powered by Google App Engine
This is Rietveld 408576698