Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1383203002: autoroller: Allow to specify Rietveld e-mail. (Closed)

Created:
5 years, 2 months ago by kjellander_webrtc
Modified:
5 years, 2 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

autoroller: Allow to specify Rietveld e-mail. This is useful in order to specify which account to be used for creating the Rietveld CL. Always pass -f to force yes to any prompts during uplaod. BUG=webrtc:4688 R=phoglund@webrtc.org Committed: https://crrev.com/42b6c634f00ca0b5e8d0f304574282a1112889cf Cr-Commit-Position: refs/heads/master@{#10165}

Patch Set 1 #

Patch Set 2 : Oops forgot to pass the variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M tools/autoroller/roll_chromium_revision.py View 1 3 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kjellander_webrtc
Ideally this e-mail would be a robot account once we've got the auto-roll running smoothly ...
5 years, 2 months ago (2015-10-05 07:14:27 UTC) #2
phoglund
lgtm
5 years, 2 months ago (2015-10-05 08:19:41 UTC) #3
kjellander_webrtc
Committed patchset #2 (id:20001) manually as 42b6c634f00ca0b5e8d0f304574282a1112889cf (presubmit successful).
5 years, 2 months ago (2015-10-05 08:44:42 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 08:44:43 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/42b6c634f00ca0b5e8d0f304574282a1112889cf
Cr-Commit-Position: refs/heads/master@{#10165}

Powered by Google App Engine
This is Rietveld 408576698