Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: tools/autoroller/roll_chromium_revision.py

Issue 1383203002: autoroller: Allow to specify Rietveld e-mail. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Oops forgot to pass the variable Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/autoroller/roll_chromium_revision.py
diff --git a/tools/autoroller/roll_chromium_revision.py b/tools/autoroller/roll_chromium_revision.py
index 4331a2c08aed6cf621e0fb7c34a63e21c8ca979d..917ecd657042623350e5d59b3f72c7648697007c 100755
--- a/tools/autoroller/roll_chromium_revision.py
+++ b/tools/autoroller/roll_chromium_revision.py
@@ -349,10 +349,13 @@ def _LocalCommit(commit_msg, dry_run):
_RunCommand(['git', 'commit', '-m', commit_msg])
-def _UploadCL(dry_run):
+def _UploadCL(dry_run, rietveld_email=None):
logging.info('Uploading CL...')
if not dry_run:
- _RunCommand(['git', 'cl', 'upload'], extra_env={'EDITOR': 'true'})
+ cmd = ['git', 'cl', 'upload', '-f']
+ if rietveld_email:
+ cmd.append('--email=%s' % rietveld_email)
+ _RunCommand(cmd, extra_env={'EDITOR': 'true'})
def _LaunchTrybots(dry_run, skip_try):
@@ -375,6 +378,10 @@ def main():
p.add_argument('-r', '--revision',
help=('Chromium Git revision to roll to. Defaults to the '
'Chromium HEAD revision if omitted.'))
+ p.add_argument('-u', '--rietveld-email',
+ help=('E-mail address to use for creating the CL at Rietveld'
+ 'If omitted a previously cached one will be used or an '
+ 'error will be thrown during upload.'))
p.add_argument('--dry-run', action='store_true', default=False,
help=('Calculate changes and modify DEPS, but don\'t create '
'any local branch, commit, upload CL or send any '
@@ -439,7 +446,7 @@ def main():
_CreateRollBranch(opts.dry_run)
UpdateDeps(deps_filename, current_cr_rev, new_cr_rev)
_LocalCommit(commit_msg, opts.dry_run)
- _UploadCL(opts.dry_run)
+ _UploadCL(opts.dry_run, opts.rietveld_email)
_LaunchTrybots(opts.dry_run, opts.skip_try)
_SendToCQ(opts.dry_run, opts.skip_cq)
return 0
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698