Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 1378513003: Change 'mute' parameter of MediaChannel::SetAudioSend()/SetVideoSend() to 'enable'. (Closed)

Created:
5 years, 2 months ago by the sun
Modified:
5 years, 2 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, kwiberg-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change 'mute' parameter of MediaChannel::SetAudioSend()/SetVideoSend() to 'enable'. BUG=webrtc:4690 Committed: https://crrev.com/dfc8f4ff8731390828884a0a91b99e51f2950275 Cr-Commit-Position: refs/heads/master@{#10130}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -49 lines) Patch
M talk/app/webrtc/webrtcsession.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M talk/media/base/fakemediaengine.h View 2 chunks +6 lines, -6 lines 0 comments Download
M talk/media/base/mediachannel.h View 2 chunks +3 lines, -2 lines 0 comments Download
M talk/media/base/videoengine_unittest.h View 1 chunk +8 lines, -8 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M talk/session/media/channel.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M talk/session/media/channel.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M talk/session/media/channel_unittest.cc View 1 2 chunks +10 lines, -10 lines 0 comments Download
M talk/session/media/channelmanager.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
the sun
5 years, 2 months ago (2015-09-29 11:27:31 UTC) #2
pthatcher1
lgtm
5 years, 2 months ago (2015-09-30 22:49:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378513003/20001
5 years, 2 months ago (2015-10-01 08:30:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-01 09:31:15 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 09:32:49 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dfc8f4ff8731390828884a0a91b99e51f2950275
Cr-Commit-Position: refs/heads/master@{#10130}

Powered by Google App Engine
This is Rietveld 408576698