Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1528)

Unified Diff: talk/media/webrtc/webrtcvoiceengine.cc

Issue 1378513003: Change 'mute' parameter of MediaChannel::SetAudioSend()/SetVideoSend() to 'enable'. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/media/webrtc/webrtcvoiceengine.h ('k') | talk/session/media/channel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/media/webrtc/webrtcvoiceengine.cc
diff --git a/talk/media/webrtc/webrtcvoiceengine.cc b/talk/media/webrtc/webrtcvoiceengine.cc
index 2f73cdd58fa56dc8cc873570ae90b1bb2b294a13..ac37425886eb40e1b9f0b0aff55f5d6c314038e3 100644
--- a/talk/media/webrtc/webrtcvoiceengine.cc
+++ b/talk/media/webrtc/webrtcvoiceengine.cc
@@ -2085,7 +2085,7 @@ bool WebRtcVoiceMediaChannel::ChangeSend(int channel, SendFlags send) {
return true;
}
-bool WebRtcVoiceMediaChannel::SetAudioSend(uint32 ssrc, bool mute,
+bool WebRtcVoiceMediaChannel::SetAudioSend(uint32 ssrc, bool enable,
const AudioOptions* options,
AudioRenderer* renderer) {
// TODO(solenberg): The state change should be fully rolled back if any one of
@@ -2093,10 +2093,10 @@ bool WebRtcVoiceMediaChannel::SetAudioSend(uint32 ssrc, bool mute,
if (!SetLocalRenderer(ssrc, renderer)) {
return false;
}
- if (!MuteStream(ssrc, mute)) {
+ if (!MuteStream(ssrc, !enable)) {
return false;
}
- if (!mute && options) {
+ if (enable && options) {
return SetOptions(*options);
}
return true;
« no previous file with comments | « talk/media/webrtc/webrtcvoiceengine.h ('k') | talk/session/media/channel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698