webrtc/modules/audio_device/android/audio_record_jni.cc - Issue 1373443003: Modifies invalid DCHECK in AudioRecordJni::OnCacheDirectBufferAddress()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_device/android/audio_record_jni.cc

Issue 1373443003: Modifies invalid DCHECK in AudioRecordJni::OnCacheDirectBufferAddress() (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/audio_device/android/audio_record_jni.cc

diff --git a/webrtc/modules/audio_device/android/audio_record_jni.cc b/webrtc/modules/audio_device/android/audio_record_jni.cc

index 8f43e4370b93dfbdf033188e1342f8c34677021d..7e3d43668ae8cf332e894be90f26bccd27c3c7d1 100644

--- a/webrtc/modules/audio_device/android/audio_record_jni.cc

+++ b/webrtc/modules/audio_device/android/audio_record_jni.cc

@@ -223,7 +223,6 @@ void AudioRecordJni::OnCacheDirectBufferAddress(

JNIEnv* env, jobject byte_buffer) {

ALOGD("OnCacheDirectBufferAddress");

RTC_DCHECK(thread_checker_.CalledOnValidThread());

- RTC_DCHECK(!direct_buffer_address_);

magjed_webrtc 2015/09/25 09:18:24 Would it be possible to keep this check if you cle

henrika_webrtc 2015/09/25 09:26:46 Good point. Let me check ;-)

direct_buffer_address_ =

env->GetDirectBufferAddress(byte_buffer);

jlong capacity = env->GetDirectBufferCapacity(byte_buffer);

« no previous file with comments | « webrtc/modules/audio_device/android/audio_device_unittest.cc ('k') | no next file » | no next file with comments »