Modifies invalid DCHECK in AudioRecordJni::OnCacheDirectBufferAddress()

webrtc/modules/audio_device/android/audio_record_jni.cc

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 205 matching lines @@
     JNIEnv* env, jobject obj, jobject byte_buffer, jlong nativeAudioRecord) {
   webrtc::AudioRecordJni* this_object =
       reinterpret_cast<webrtc::AudioRecordJni*> (nativeAudioRecord);
   this_object->OnCacheDirectBufferAddress(env, byte_buffer);
 }
 
 void AudioRecordJni::OnCacheDirectBufferAddress(
     JNIEnv* env, jobject byte_buffer) {
   ALOGD("OnCacheDirectBufferAddress");
   RTC_DCHECK(thread_checker_.CalledOnValidThread());
-  RTC_DCHECK(!direct_buffer_address_);

[magjed_webrtc, 2015/09/25 09:18:24]

Would it be possible to keep this check if you clear |direct_buffer_address_| in
StopRecording()?

[henrika_webrtc, 2015/09/25 09:26:46]

Good point. Let me check ;-)

   direct_buffer_address_ =
       env->GetDirectBufferAddress(byte_buffer);
   jlong capacity = env->GetDirectBufferCapacity(byte_buffer);
   ALOGD("direct buffer capacity: %lld", capacity);
   direct_buffer_capacity_in_bytes_ = static_cast<size_t>(capacity);
 }
 
 void JNICALL AudioRecordJni::DataIsRecorded(
   JNIEnv* env, jobject obj, jint length, jlong nativeAudioRecord) {
   webrtc::AudioRecordJni* this_object =
@@ skipping 16 matching lines @@
   // of |playDelayMs| and |recDelayMs|, hence the distributions does not matter.
   audio_device_buffer_->SetVQEData(total_delay_in_milliseconds_,
                                    0,   // recDelayMs
                                    0);  // clockDrift
   if (audio_device_buffer_->DeliverRecordedData() == -1) {
     ALOGE("AudioDeviceBuffer::DeliverRecordedData failed!");
   }
 }
 
 }  // namespace webrtc