Modifies invalid DCHECK in AudioRecordJni::OnCacheDirectBufferAddress()

Modifies invalid DCHECK in AudioRecordJni::OnCacheDirectBufferAddress()

Ensures that we can restart audio recording on Android without hitting
a DCHECK. Also adds a symmetric design for the playout side.

BUG=webrtc:5000
TEST=modules_unittests --gtest_filter=AudioDevice*

Committed: https://crrev.com/82e20554cbf8152d67915e3ef764bad8064b6541
Cr-Commit-Position: refs/heads/master@{#10072}

[henrika_webrtc, 2015-09-25 09:08:01]

henrika@webrtc.org changed reviewers:
+ magjed@webrtc.org

[henrika_webrtc, 2015-09-25 09:09:42]

PTAL

[magjed_webrtc, 2015-09-25 09:18:24]

https://codereview.webrtc.org/1373443003/diff/1/webrtc/modules/audio_device/a...
File webrtc/modules/audio_device/android/audio_record_jni.cc (left):

https://codereview.webrtc.org/1373443003/diff/1/webrtc/modules/audio_device/a...
webrtc/modules/audio_device/android/audio_record_jni.cc:226:
RTC_DCHECK(!direct_buffer_address_);
Would it be possible to keep this check if you clear |direct_buffer_address_| in
StopRecording()?

[henrika_webrtc, 2015-09-25 09:26:46]

Done. Added same approach on playout side as well.

https://codereview.webrtc.org/1373443003/diff/1/webrtc/modules/audio_device/a...
File webrtc/modules/audio_device/android/audio_record_jni.cc (left):

https://codereview.webrtc.org/1373443003/diff/1/webrtc/modules/audio_device/a...
webrtc/modules/audio_device/android/audio_record_jni.cc:226:
RTC_DCHECK(!direct_buffer_address_);
Good point. Let me check ;-)

[magjed_webrtc, 2015-09-25 09:54:07]

lgtm if you update CL description.

https://codereview.webrtc.org/1373443003/diff/20001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/android/audio_track_jni.cc (right):

https://codereview.webrtc.org/1373443003/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/audio_track_jni.cc:220:
direct_buffer_address_ =
Add a check here as well?

[henrika_webrtc, 2015-09-25 10:38:43]

https://codereview.webrtc.org/1373443003/diff/20001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/android/audio_track_jni.cc (right):

https://codereview.webrtc.org/1373443003/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/audio_track_jni.cc:220:
direct_buffer_address_ =
On 2015/09/25 09:54:07, magjed_webrtc wrote:
> Add a check here as well?

Done.

[henrika_webrtc, 2015-09-25 10:45:45]

The CQ bit was checked by henrika@webrtc.org

[henrika_webrtc, 2015-09-25 10:45:45]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1373443003/#ps40001 (title:
"nit")

[commit-bot: I haz the power, 2015-09-25 10:45:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1373443003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1373443003/40001

[commit-bot: I haz the power, 2015-09-25 11:26:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-25 11:26:28]

Patchset 3 (id:??) landed as
https://crrev.com/82e20554cbf8152d67915e3ef764bad8064b6541
Cr-Commit-Position: refs/heads/master@{#10072}