Issue 1370653002: Reland of "Android GlRectDrawer: Add test for RGB rendering"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1370653002: Reland of "Android GlRectDrawer: Add test for RGB rendering" (Closed)

Created:
5 years, 2 months ago by magjed_webrtc

Modified:
5 years, 2 months ago

Reviewers:
hbos

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Reland of "Android GlRectDrawer: Add test for RGB rendering" Reland of https://codereview.webrtc.org/1367923002/. The bug was that not all platforms support glReadPixels() with GL_RGB. This CL uses GL_RGBA instead. BUG=webrtc:4742 R=hbos@webrtc.org Committed: https://crrev.com/495d2fdd6569c252aebf0bae5c7cab0a207dd6dc Cr-Commit-Position: refs/heads/master@{#10070}

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -2 lines)			Patch
	M	talk/app/webrtc/androidtests/src/org/webrtc/GlRectDrawerTest.java	View	1	3 chunks	+84 lines, -2 lines	0 comments	Download

Total messages: 6 (1 generated)

magjed_webrtc

Committed patchset #2 (id:20001) manually as 495d2fdd6569c252aebf0bae5c7cab0a207dd6dc (presubmit successful).

5 years, 2 months ago (2015-09-25 08:55:48 UTC) #5

commit-bot: I haz the power

5 years, 2 months ago (2015-09-25 08:55:51 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/495d2fdd6569c252aebf0bae5c7cab0a207dd6dc
Cr-Commit-Position: refs/heads/master@{#10070}