Update build file to use asmflags instead of cflags.

Update build file to use asmflags instead of cflags.

The assembler toolchains are changing to replace cflags/cflags_c with asmflags
(https://codereview.chromium.org/1368223002/). This part one of a two-part change
to deprecate using cflags when compiling assembly code.

BUG=none
R=andrew@webrtc.org, brettw@chromium.org

Committed: https://chromium.googlesource.com/external/webrtc/deps/third_party/openmax/+/eb6f534cd5945e8a8cfdd0ab41bc6a18501e4ed8

[Bons, 2015-09-28 03:56:16]

The CQ bit was checked by andybons@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-28 03:56:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1369183002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1369183002/1

[commit-bot: I haz the power, 2015-09-28 03:56:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 03:56:24]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Bons, 2015-09-28 03:57:21]

andybons@chromium.org changed reviewers:
+ ajm@google.com, brettw@chromium.org, kma@google.com, rtoy@google.com

[brettw, 2015-09-28 04:37:50]

lgtm

https://codereview.webrtc.org/1369183002/diff/1/dl/BUILD.gn
File dl/BUILD.gn (right):

https://codereview.webrtc.org/1369183002/diff/1/dl/BUILD.gn#newcode202
dl/BUILD.gn:202: // TODO(andybons): Remove once the toolchains have been
updated.
# for comments.

Can you also clarify what's to be removed (I assume "cflags").

[Bons, 2015-09-28 04:42:54]

https://codereview.webrtc.org/1369183002/diff/1/dl/BUILD.gn
File dl/BUILD.gn (right):

https://codereview.webrtc.org/1369183002/diff/1/dl/BUILD.gn#newcode202
dl/BUILD.gn:202: // TODO(andybons): Remove once the toolchains have been
updated.
On 2015/09/28 04:37:50, brettw wrote:
> # for comments.
> 
> Can you also clarify what's to be removed (I assume "cflags").

Done.

[Andrew MacDonald, 2015-09-28 05:24:29]

andrew@webrtc.org changed reviewers:
- kma@google.com

[Andrew MacDonald, 2015-09-28 05:24:46]

andrew@webrtc.org changed reviewers:
+ andrew@webrtc.org

[Andrew MacDonald, 2015-09-28 05:24:46]

lgtm

[Bons, 2015-09-28 12:34:20]

The CQ bit was checked by andybons@chromium.org

[Bons, 2015-09-28 12:34:21]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.webrtc.org/1369183002/#ps20001 (title:
" ")

[commit-bot: I haz the power, 2015-09-28 12:34:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1369183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1369183002/20001

[commit-bot: I haz the power, 2015-09-28 12:34:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 12:34:31]

CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true
and NOPRESUBMIT=true in order for the CQ to process them

[Bons, 2015-09-28 12:36:39]

The CQ bit was checked by andybons@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-28 12:36:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1369183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1369183002/20001

[commit-bot: I haz the power, 2015-09-28 12:36:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 12:36:52]

Dry run: CLs for remote refs other than refs/pending/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[Bons, 2015-09-28 15:05:16]

On 2015/09/28 12:36:52, commit-bot: I haz the power wrote:
> Dry run: CLs for remote refs other than refs/pending/heads/master must contain
> NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

Andrew, how should I land this?

[Andrew MacDonald, 2015-09-28 15:29:58]

On 2015/09/28 15:05:16, Bons wrote:
> On 2015/09/28 12:36:52, commit-bot: I haz the power wrote:
> > Dry run: CLs for remote refs other than refs/pending/heads/master must
contain
> > NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
> 
> Andrew, how should I land this?

Ah yeah, sorry, the CQ doesn't work for this repo. I'll land this manually.

[Raymond Toy (Google), 2015-09-28 15:47:18]

Does dl.gyp need to be changed too?
And does this change only for ARM builds?

[Bons, 2015-09-28 15:54:53]

On 2015/09/28 15:47:18, Raymond Toy (Google) wrote:
> Does dl.gyp need to be changed too?
No. This is a GN-only change. More context here:
https://codereview.chromium.org/1368223002/

> And does this change only for ARM builds?
The above change changes the behavior of the toolchains so that cflags and
cflags_c are NOT passed to assemblers anymore. So if you are setting cflags or
cflags_c for targets that have .S or .asm files, then those should change to
include asmflags (or replace cflags in the case where it’s just source files
that are .S or .asm.

[Bons, 2015-09-28 17:14:32]

On 2015/09/28 15:54:53, Bons wrote:
> On 2015/09/28 15:47:18, Raymond Toy (Google) wrote:
> > Does dl.gyp need to be changed too?
> No. This is a GN-only change. More context here:
> https://codereview.chromium.org/1368223002/
> 
> > And does this change only for ARM builds?
> The above change changes the behavior of the toolchains so that cflags and
> cflags_c are NOT passed to assemblers anymore. So if you are setting cflags or
> cflags_c for targets that have .S or .asm files, then those should change to
> include asmflags (or replace cflags in the case where it’s just source files
> that are .S or .asm.

I’m assuming this issue will be updated when it’s landed?

Once this lands (and everything seems OK), I will land
https://codereview.chromium.org/1368223002/ then submit another patch to resolve
the TODO introduced here, so keep an eye out for one more review assuming things
don’t blow up :)

[Raymond Toy (Google), 2015-09-28 17:19:53]

On 2015/09/28 15:54:53, Bons wrote:
> On 2015/09/28 15:47:18, Raymond Toy (Google) wrote:
> > Does dl.gyp need to be changed too?
> No. This is a GN-only change. More context here:
> https://codereview.chromium.org/1368223002/
> 
> > And does this change only for ARM builds?
> The above change changes the behavior of the toolchains so that cflags and
> cflags_c are NOT passed to assemblers anymore. So if you are setting cflags or
> cflags_c for targets that have .S or .asm files, then those should change to
> include asmflags (or replace cflags in the case where it’s just source files
> that are .S or .asm.

Ah, ok.  Only the arm builds have assembly files; all the other architectures
are written in C.

[Bons, 2015-09-28 17:25:55]

On 2015/09/28 17:19:53, Raymond Toy (Google) wrote:
> On 2015/09/28 15:54:53, Bons wrote:
> > On 2015/09/28 15:47:18, Raymond Toy (Google) wrote:
> > > Does dl.gyp need to be changed too?
> > No. This is a GN-only change. More context here:
> > https://codereview.chromium.org/1368223002/
> > 
> > > And does this change only for ARM builds?
> > The above change changes the behavior of the toolchains so that cflags and
> > cflags_c are NOT passed to assemblers anymore. So if you are setting cflags
or
> > cflags_c for targets that have .S or .asm files, then those should change to
> > include asmflags (or replace cflags in the case where it’s just source files
> > that are .S or .asm.
> 
> Ah, ok.  Only the arm builds have assembly files; all the other architectures
> are written in C.

Then you should be good to go with cflags/cflags_c :)

[Andrew MacDonald, 2015-09-28 19:24:38]

Committed patchset #2 (id:20001) manually as
eb6f534cd5945e8a8cfdd0ab41bc6a18501e4ed8 (presubmit successful).