Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc

Issue 1365043002: Set RtcpSender transport at construction. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Cleanup Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_sender.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc
index a03af2435fff9ca4cd862043adbfe2df9a8fe2fa..e72b37863e83b2c935ab4af5b66e9db6bf17c522 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc
@@ -81,18 +81,17 @@ class RtcpFormatRembTest : public ::testing::Test {
};
void RtcpFormatRembTest::SetUp() {
+ rtcp_receiver_ = new RTCPReceiver(system_clock_, false, nullptr, nullptr,
+ nullptr, dummy_rtp_rtcp_impl_);
+ test_transport_ = new TestTransport(rtcp_receiver_);
RtpRtcp::Configuration configuration;
configuration.audio = false;
configuration.clock = system_clock_;
configuration.remote_bitrate_estimator = remote_bitrate_estimator_.get();
+ configuration.outgoing_transport = test_transport_;
dummy_rtp_rtcp_impl_ = new ModuleRtpRtcpImpl(configuration);
- rtcp_sender_ =
- new RTCPSender(false, system_clock_, receive_statistics_.get(), NULL);
- rtcp_receiver_ = new RTCPReceiver(system_clock_, false, NULL, NULL, NULL,
- dummy_rtp_rtcp_impl_);
- test_transport_ = new TestTransport(rtcp_receiver_);
-
- EXPECT_EQ(0, rtcp_sender_->RegisterSendTransport(test_transport_));
+ rtcp_sender_ = new RTCPSender(false, system_clock_, receive_statistics_.get(),
+ nullptr, test_transport_);
pbos-webrtc 2015/09/24 11:52:02 Since this isn't using configuration or dummy_...,
sprang_webrtc 2015/09/24 12:08:10 Done.
}
void RtcpFormatRembTest::TearDown() {
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_sender.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698